Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js

Issue 2601333002: Update json_schema_compiler to handle the Automation extension API (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
index 7c0eb03eb6a4938f2f48b0cd88ffdfa7645bd46b..db1c1323fa4817b6bc15db0b72273cb75ac14eda 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
@@ -14,6 +14,7 @@ goog.scope(function() {
var AutomationNode = chrome.automation.AutomationNode;
var RoleType = chrome.automation.RoleType;
var TreeChange = chrome.automation.TreeChange;
+var TreeChangeObserverFilter = chrome.automation.TreeChangeObserverFilter;
/**
* ChromeVox2 live region handler.
@@ -43,7 +44,8 @@ LiveRegions = function(chromeVoxState) {
*/
this.liveRegionNodeSet_ = new WeakSet();
chrome.automation.addTreeChangeObserver(
- 'liveRegionTreeChanges', this.onTreeChange.bind(this));
+ TreeChangeObserverFilter.LIVE_REGION_TREE_CHANGES,
+ this.onTreeChange.bind(this));
};
/**
@@ -91,7 +93,7 @@ LiveRegions.prototype = {
var webView = AutomationUtil.getTopLevelRoot(node);
webView = webView ? webView.parent : null;
if (!LiveRegions.announceLiveRegionsFromBackgroundTabs_ &&
- currentRange.start.node.role != RoleType.desktop &&
+ currentRange.start.node.role != RoleType.DESKTOP &&
(!webView || !webView.state.focused)) {
return;
}
@@ -135,7 +137,7 @@ LiveRegions.prototype = {
}
// Alerts should be announced as a result of focus.
- if (node.role == RoleType.alert)
+ if (node.role == RoleType.ALERT)
return;
var range = cursors.Range.fromNode(node);

Powered by Google App Engine
This is Rietveld 408576698