chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js - Issue 2601333002: Update json_schema_compiler to handle the Automation extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

Issue 2601333002: Update json_schema_compiler to handle the Automation extension API (Closed)

Patch Set: Optional to nullable Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/automation.idl ('K') | « chrome/test/data/extensions/api_test/automation/tests/tabs/bounds_for_range.js ('k') | chrome/test/data/extensions/api_test/automation/tests/tabs/document_selection.js » ('j') | tools/json_schema_compiler/idl_schema.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

index 6190449c7ec82602310d390f79034afac2759d1a..f63c00bc5156eedc97a249c9f32dd394148b1dd1 100644

--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

@@ -10,7 +10,7 @@ var allTests = [

var button = rootNode.find({role: 'button'});

assertEq(rootNode, button.root);

- rootNode.addEventListener(EventType.destroyed, function() {

+ rootNode.addEventListener('destroyed', function() {

// Poll until the root node doesn't have a role anymore

// indicating that it really did get cleaned up.

function checkSuccess() {