chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js - Issue 2601333002: Update json_schema_compiler to handle the Automation extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

Issue 2601333002: Update json_schema_compiler to handle the Automation extension API (Closed)

Patch Set: Address lots of feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('K') | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js » ('j') | tools/json_schema_compiler/idl_schema.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

index 4d6a4d7c3caa50e85d10293f86d0c48a679198b3..5c5f078e7c0a97931cf02b99461eaf4d1d3f242b 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

@@ -802,7 +802,7 @@ Panel.getCallbackForCurrentItem = function() {

Panel.closeMenusAndRestoreFocus = function() {

// Watch for the next focus event.

var onFocus = function(desktop, evt) {

- desktop.removeEventListener(chrome.automation.EventType.focus, onFocus);

+ desktop.removeEventListener(chrome.automation.EventType.FOCUS, onFocus);

if (Panel.pendingCallback_) {

// Clear it before calling it, in case the callback itself triggers

// another pending callback.

@@ -815,7 +815,7 @@ Panel.closeMenusAndRestoreFocus = function() {

chrome.automation.getDesktop(function(desktop) {

onFocus = /** @type {function(chrome.automation.AutomationEvent)} */(

onFocus.bind(this, desktop));

- desktop.addEventListener(chrome.automation.EventType.focus,

+ desktop.addEventListener(chrome.automation.EventType.FOCUS,

onFocus,

true);