Update json_schema_compiler to handle the Automation extension API

tools/json_schema_compiler/js_util.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from code import Code
 from model import PropertyType
 
 from datetime import datetime
 
 LICENSE = """// Copyright %s The Chromium Authors. All rights reserved.
@@ skipping 83 matching lines @@
                    self._TypeToJsType(namespace_name, function.returns),
                    '', False, function.returns.description)
 
     if function.deprecated:
       c.Append('@deprecated %s' % function.deprecated)
 
     c.Append(self.GetSeeLink(namespace_name, 'method', function.name))
 
     c.Eblock(' */')
 
+  def AppendTypeJsDoc(self, c, namespace_name, js_type, optional):

[Dan Beam, 2017/01/11 23:04:26]

s/optional/nullable/

optional means {type=} in JSDoc, not {?type}

maybe also make this a named key?  i.e. nullable=False

so from callsites instead of

  thing.AppendTypeJsDoc(c, 'namespace', 'Type', True)

you see (or at least could see):

  thing.AppendTypeJsDoc(c, 'namespace', 'Type', nullable=True)

[dmazzoni, 2017/01/11 23:23:57]

Done.

+    """Appends the documentation for a type as a Code.
+    """
+    c.Append('@type {')
+    js_type_str = self._TypeToJsType(namespace_name, js_type).Render()
+    if optional:
+      if js_type_str[0] == '!':

[Dan Beam, 2017/01/11 23:04:26]

when does a nullable param have a !Type?  these are basically mutually exclusive

[dmazzoni, 2017/01/11 23:23:57]

Exactly, but _TypeToJsType, below, always adds '!' by default
when it encounters a REF, so we have to undo it here.

+        js_type_str = js_type_str[1:]
+      js_type_str = '?' + js_type_str
+    c.Append(js_type_str, new_line=False)
+    c.Append('}', new_line=False)
+
   def _FunctionToJsFunction(self, namespace_name, function):
     """Converts a model.Function to a JS type (i.e., function([params])...)"""
     c = Code()
     c.Append('function(')
     for i, param in enumerate(function.params):
       c.Concat(self._TypeToJsType(namespace_name, param.type_), new_line=False)
       if i is not len(function.params) - 1:
         c.Append(', ', new_line=False, strip_right=False)
     c.Append('):', new_line=False)
 
@@ skipping 46 matching lines @@
     """Returns a @see link for a given API 'object' (type, method, or event).
     """
 
     # NOTE(devlin): This is kind of a hack. Some APIs will be hosted on
     # developer.chrome.com/apps/ instead of /extensions/, and some APIs have
     # '.'s in them (like app.window), which should resolve to 'app_window'.
     # Luckily, the doc server has excellent url resolution, and knows exactly
     # what we mean. This saves us from needing any complicated logic here.
     return ('@see https://developer.chrome.com/extensions/%s#%s-%s' %
                 (namespace_name, object_type, object_name))