[MD settings] stream i18n replacement without large accumulation buffer

content/browser/webui/i18n_source_stream_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "content/browser/webui/i18n_source_stream.h"
 #include "net/base/io_buffer.h"
 #include "net/base/test_completion_callback.h"
 #include "net/filter/mock_source_stream.h"
@@ skipping 160 matching lines @@
   int result = ReadStream(&actual_output);
   EXPECT_EQ(net::OK, result);
   EXPECT_EQ("i18n", stream()->Description());
 }
 
 TEST_P(I18nSourceStreamTest, NoTranslations) {
   Init();
   const char kText[] = "This text has no i18n replacements.";
   size_t kTextLength = strlen(kText);
   source()->AddReadResult(kText, kTextLength, net::OK, GetParam().mode);
-  source()->AddReadResult(kText + kTextLength, 0, net::OK, GetParam().mode);
+  source()->AddReadResult(nullptr, 0, net::OK, GetParam().mode);
   std::string actual_output;
   int rv = ReadStream(&actual_output);
   EXPECT_EQ(static_cast<int>(kTextLength), rv);
-  EXPECT_EQ(std::string(kText, kTextLength), actual_output);
+  EXPECT_EQ(kText, actual_output);
   EXPECT_EQ("i18n", stream()->Description());
 }
 
 TEST_P(I18nSourceStreamTest, I18nOneRead) {
   Init();
   source()->AddReadResult(source_data(), kSourceSize, net::OK, GetParam().mode);
-  source()->AddReadResult(source_data() + kSourceSize, 0, net::OK,
-                          GetParam().mode);
+  source()->AddReadResult(nullptr, 0, net::OK, GetParam().mode);
   std::string actual_output;
   int rv = ReadStream(&actual_output);
   EXPECT_EQ(static_cast<int>(kResultSize), rv);
   EXPECT_EQ(std::string(result_data(), kResultSize), actual_output);
   EXPECT_EQ("i18n", stream()->Description());
 }
 
 TEST_P(I18nSourceStreamTest, I18nInMultipleReads) {
   Init();
   size_t chunk_size = 5;
   size_t written = 0;
   while (written + chunk_size < kSourceSize) {
     source()->AddReadResult(source_data() + written, chunk_size, net::OK,
                             GetParam().mode);
     written += chunk_size;
   }
   source()->AddReadResult(source_data() + written, kSourceSize - written,
                           net::OK, GetParam().mode);
-  source()->AddReadResult(source_data() + kSourceSize, 0, net::OK,
-                          GetParam().mode);
+  source()->AddReadResult(nullptr, 0, net::OK, GetParam().mode);
   std::string actual_output;
   int rv = ReadStream(&actual_output);
   EXPECT_EQ(static_cast<int>(kResultSize), rv);
   EXPECT_EQ(std::string(result_data(), kResultSize), actual_output);
   EXPECT_EQ("i18n", stream()->Description());
 }
 
+TEST_P(I18nSourceStreamTest, I18nTagAtEndOfLine) {
+  Init();
+  const char kSourceData[] = "test with tag at end of line $";
+  const size_t source_size = strlen(kSourceData);
+  source()->AddReadResult(kSourceData, source_size, net::OK, GetParam().mode);
+  source()->AddReadResult(nullptr, 0, net::OK, GetParam().mode);
+  std::string actual_output;
+  int rv = ReadStream(&actual_output);
+  EXPECT_EQ(static_cast<int>(source_size), rv);
+  EXPECT_EQ(kSourceData, actual_output);
+  EXPECT_EQ("i18n", stream()->Description());
+}
+
 }  // namespace content