[MD settings] stream i18n replacement without large accumulation buffer

content/browser/webui/i18n_source_stream_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "content/browser/webui/i18n_source_stream.h"
 #include "net/base/io_buffer.h"
 #include "net/base/test_completion_callback.h"
 #include "net/filter/mock_source_stream.h"
@@ skipping 200 matching lines @@
                           net::OK, GetParam().mode);
   source()->AddReadResult(source_data() + kSourceSize, 0, net::OK,
                           GetParam().mode);
   std::string actual_output;
   int rv = ReadStream(&actual_output);
   EXPECT_EQ(static_cast<int>(kResultSize), rv);
   EXPECT_EQ(std::string(result_data(), kResultSize), actual_output);
   EXPECT_EQ("i18n", stream()->Description());
 }
 
+TEST_P(I18nSourceStreamTest, I18nTagAtEndOfLine) {
+  Init();
+  const char source_data[] = "test with tag at end of line $";

[mmenke, 2017/01/03 20:47:32]

nit:  kSourceData

[dschuyler, 2017/01/03 21:51:40]

Done.

+  const size_t source_size = strlen(source_data);
+  source()->AddReadResult(source_data, source_size, net::OK, GetParam().mode);
+  source()->AddReadResult(source_data + source_size, 0, net::OK,

[mmenke, 2017/01/03 20:47:32]

Know it's what the other tests do, but the first argument here really should
just be nullptr.  Feel free to update the other tests, or not.

[dschuyler, 2017/01/03 21:51:40]

Done.

+                          GetParam().mode);
+  std::string actual_output;
+  int rv = ReadStream(&actual_output);
+  EXPECT_EQ(static_cast<int>(source_size), rv);
+  EXPECT_EQ(std::string(source_data, source_size), actual_output);

[mmenke, 2017/01/03 20:47:32]

std::string(source_data, source_size) -> source_data.  It will be implicitly
converted to an std::string.  Again, can optionally update other tests
similarly.

[dschuyler, 2017/01/03 21:51:40]

Done.

+  EXPECT_EQ("i18n", stream()->Description());
+}
+
 }  // namespace content