Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7576)

Unified Diff: chrome/browser/safe_browsing/download_protection_service.h

Issue 2601303002: Wireup SafeBrowsingNavigationObserverManager to help PPAPI download attribution (Closed)
Patch Set: nit Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/download_protection_service.h
diff --git a/chrome/browser/safe_browsing/download_protection_service.h b/chrome/browser/safe_browsing/download_protection_service.h
index 213e2a7443eecf4c0ca144ecd003b68c8b9d7564..53aec789cff52b54db8bec28e455b3c9f2675425 100644
--- a/chrome/browser/safe_browsing/download_protection_service.h
+++ b/chrome/browser/safe_browsing/download_protection_service.h
@@ -129,6 +129,8 @@ class DownloadProtectionService {
virtual void CheckPPAPIDownloadRequest(
const GURL& requestor_url,
+ const GURL& initiating_frame_url,
+ content::WebContents* web_contents,
const base::FilePath& default_file_path,
const std::vector<base::FilePath::StringType>& alternate_extensions,
Profile* profile,
@@ -296,6 +298,15 @@ class DownloadProtectionService {
content::WebContents* web_contents,
ClientDownloadRequest* out_request);
+ // If kDownloadAttribution feature is enabled, identify referrer chain of the
+ // PPAPI download based on the frame URL where the download is initiated.
+ // Then add referrer chain info of to ClientDownloadRequest proto. This
Nathan Parker 2017/01/04 19:49:12 s/ of//
Jialiu Lin 2017/01/04 21:53:35 Done.
+ // function also records UMA stats of download attribution result.
+ void AddReferrerChainToPPAPIClientDownloadRequest(
+ const GURL& initiating_frame_url,
+ content::WebContents* web_contents,
+ ClientDownloadRequest* out_request);
+
// These pointers may be NULL if SafeBrowsing is disabled.
scoped_refptr<SafeBrowsingUIManager> ui_manager_;
scoped_refptr<SafeBrowsingDatabaseManager> database_manager_;

Powered by Google App Engine
This is Rietveld 408576698