chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html - Issue 2601303002: Wireup SafeBrowsingNavigationObserverManager to help PPAPI download attribution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

Issue 2601303002: Wireup SafeBrowsingNavigationObserverManager to help PPAPI download attribution (Closed)

Patch Set: add check for rfh Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc ('k') | chrome/test/ppapi/ppapi_filechooser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

diff --git a/chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html b/chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

index bde0c0b89fc7714bd97110d4ef3e1a6bf44f6255..904b1c64015d59387e7c6881fb18df78bdd173c4 100644

--- a/chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

+++ b/chrome/test/data/safe_browsing/download_protection/navigation_observer/navigation_observer_tests.html

@@ -115,6 +115,17 @@

Open download in new tab with data url

</a><br>

+ <a id="new_tab_download_with_server_redirect" href="#" rel="noreferrer" target=_blank>

+ Open navigation in a new tab and immediately redirect to a download by server.

+ </a><br>

+ <script>

+ var request = location.origin + "/server-redirect?" + location.origin +

+ "/safe_browsing/download_protection/signed.exe"

+ document.getElementById("new_tab_download_with_server_redirect")

+ .setAttribute('href', request);

+ </script>

Download via HTML5 file system API

</a><br>