Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 260123003: Revert of Remove smiluate-touch-screen-with-mouse content flag. (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
CC:
chromium-reviews, jam, jdduke+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert of Remove smiluate-touch-screen-with-mouse content flag. (https://codereview.chromium.org/258503003/) Reason for revert: Somewhat speculative; looks like this caused TouchEmulatorTest failures on valgrind: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28tsan%29%283%29/builds/11052 TouchEmulatorTest.Pinch: ../../content/browser/renderer_host/input/touch_emulator_unittest.cc:254: Failure Value of: ExpectedEvents() Actual: "TouchEnd GestureFlingStart" Expected: "TouchEnd GestureScrollEnd" etc Original issue's description: > Remove smiluate-touch-screen-with-mouse content flag. > > This is duplicated functionality now, as one can use DevTools touch emulation instead. > > BUG=337142 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266549 TBR=aelias@chromium.org,jochen@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=337142 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -0 lines) Patch
M content/browser/renderer_host/input/input_router_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 3 chunks +106 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
Created Revert of Remove smiluate-touch-screen-with-mouse content flag.
6 years, 7 months ago (2014-04-28 18:13:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/260123003/1
6 years, 7 months ago (2014-04-28 18:14:40 UTC) #2
commit-bot: I haz the power
Change committed as 266608
6 years, 7 months ago (2014-04-28 18:15:44 UTC) #3
jdduke (slow)
On 2014/04/28 18:15:44, I haz the power (commit-bot) wrote: > Change committed as 266608 Hmm, ...
6 years, 7 months ago (2014-04-28 18:20:31 UTC) #4
Nico
On 2014/04/28 18:20:31, jdduke wrote: > On 2014/04/28 18:15:44, I haz the power (commit-bot) wrote: ...
6 years, 7 months ago (2014-04-28 18:26:20 UTC) #5
Nico
6 years, 7 months ago (2014-04-28 18:27:04 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/256203003/ by thakis@chromium.org.

The reason for reverting is: I meant to revert
https://codereview.chromium.org/250923005/ , not this one..

Powered by Google App Engine
This is Rietveld 408576698