components/tracing/common/process_metrics_memory_dump_provider.h - Issue 2601193002: Emit VMRegions for macOS when doing process memory dumps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/common/process_metrics_memory_dump_provider.h

Issue 2601193002: Emit VMRegions for macOS when doing process memory dumps. (Closed)

Patch Set: Remove debugging. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/common/process_metrics_memory_dump_provider.h

diff --git a/components/tracing/common/process_metrics_memory_dump_provider.h b/components/tracing/common/process_metrics_memory_dump_provider.h

index 4874685f62dca887a8e795aaa84a6c6703ec4858..e87a32a798029ef58719eb43f01345ba80e876ce 100644

--- a/components/tracing/common/process_metrics_memory_dump_provider.h

+++ b/components/tracing/common/process_metrics_memory_dump_provider.h

@@ -43,6 +43,10 @@ class TRACING_EXPORT ProcessMetricsMemoryDumpProvider

FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest, DumpRSS);

FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,

TestPollFastMemoryTotal);

+#if defined(OS_MACOSX)

+ FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,

+ TestMachOReading);

+#endif // defined(OS_MACOSX)

ProcessMetricsMemoryDumpProvider(base::ProcessId process);