Added methods to surface number of zone and scoped handles for each isolate.

Added methods to surface number of zone and scoped handles for each isolate.

Added methods to surface number of zone and scoped handles in each isolate. These values are displayed in the isolate view page in the Observatory. These handle counts for the native IO isolate will be surfaced in another CL.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/82cf4cc374252c309dc053016e25caca0abb2118

[bkonyi, 2016-12-28 22:18:22]

bkonyi@google.com changed reviewers:
+ asiva@google.com, johnmccutchan@google.com, zra@google.com

[Cutch, 2017-01-03 18:16:49]

https://codereview.chromium.org/2601153002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/isolate_view.dart (right):

https://codereview.chromium.org/2601153002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/isolate_view.dart:272: ..text = 'zone
handles',
How about something more like:

"Allocated zone handle count"

(here and below)

https://codereview.chromium.org/2601153002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2601153002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:2050: jsobj.AddProperty("numZoneHandles",
zone_handle_count);
_numZoneHandles and _numScopedHandles.

[bkonyi, 2017-01-03 20:00:10]

https://codereview.chromium.org/2601153002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/isolate_view.dart (right):

https://codereview.chromium.org/2601153002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/isolate_view.dart:272: ..text = 'zone
handles',
On 2017/01/03 at 18:16:49, Cutch wrote:
> How about something more like:
> 
> "Allocated zone handle count"
> 
> (here and below)

Done.

https://codereview.chromium.org/2601153002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2601153002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:2050: jsobj.AddProperty("numZoneHandles",
zone_handle_count);
On 2017/01/03 at 18:16:49, Cutch wrote:
> _numZoneHandles and _numScopedHandles.

Done.

[siva, 2017-01-03 20:08:31]

lgtm

https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc
File runtime/vm/thread.cc (right):

https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc#newcod...
runtime/vm/thread.cc:773: }
ASSERT(count > 0);

https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc#newcod...
runtime/vm/thread.cc:784: }
ASSERT(count > 0);

[bkonyi, 2017-01-03 20:12:44]

On 2017/01/03 at 20:08:31, asiva wrote:
> lgtm
> 
> https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc
> File runtime/vm/thread.cc (right):
> 
>
https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc#newcod...
> runtime/vm/thread.cc:773: }
> ASSERT(count > 0);
> 
>
https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc#newcod...
> runtime/vm/thread.cc:784: }
> ASSERT(count > 0);

Should these asserts be count >= 0, or is there always at least one handle?

[siva, 2017-01-03 20:15:08]

On 2017/01/03 20:12:44, bkonyi wrote:
> On 2017/01/03 at 20:08:31, asiva wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc
> > File runtime/vm/thread.cc (right):
> > 
> >
>
https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc#newcod...
> > runtime/vm/thread.cc:773: }
> > ASSERT(count > 0);
> > 
> >
>
https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc#newcod...
> > runtime/vm/thread.cc:784: }
> > ASSERT(count > 0);
> 
> Should these asserts be count >= 0, or is there always at least one handle?

count >= 0 is correct.

[bkonyi, 2017-01-03 20:19:25]

On 2017/01/03 at 20:15:08, asiva wrote:
> On 2017/01/03 20:12:44, bkonyi wrote:
> > On 2017/01/03 at 20:08:31, asiva wrote:
> > > lgtm
> > > 
> > > https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc
> > > File runtime/vm/thread.cc (right):
> > > 
> > >
> >
https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc#newcod...
> > > runtime/vm/thread.cc:773: }
> > > ASSERT(count > 0);
> > > 
> > >
> >
https://codereview.chromium.org/2601153002/diff/1/runtime/vm/thread.cc#newcod...
> > > runtime/vm/thread.cc:784: }
> > > ASSERT(count > 0);
> > 
> > Should these asserts be count >= 0, or is there always at least one handle?
> 
> count >= 0 is correct.

Okay, done.

[bkonyi, 2017-01-03 20:21:26]

Description was changed from

==========
Added methods to surface number of zone and scoped handles for each isolate.

Added methods to surface number of zone and scoped handles in each isolate.
These values are displayed in the isolate view page in the Observatory. These
handle counts for the native IO isolate will be surfaced in another CL.

BUG=
==========

to

==========
Added methods to surface number of zone and scoped handles for each isolate.

Added methods to surface number of zone and scoped handles in each isolate.
These values are displayed in the isolate view page in the Observatory. These
handle counts for the native IO isolate will be surfaced in another CL.

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/82cf4cc374252c309dc053016e25caca0abb2118
==========

[bkonyi, 2017-01-03 20:21:27]

Committed patchset #3 (id:40001) manually as
82cf4cc374252c309dc053016e25caca0abb2118 (presubmit successful).