Chromium Code Reviews Chromium Code Reviews
Issue 260113004:
Don't squash layers that have a clip or overflow clip. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/compositing/squashing/clip-composited-descendant.html |
| diff --git a/LayoutTests/compositing/squashing/repaint-child-of-squashed.html b/LayoutTests/compositing/squashing/clip-composited-descendant.html |
| similarity index 66% |
| copy from LayoutTests/compositing/squashing/repaint-child-of-squashed.html |
| copy to LayoutTests/compositing/squashing/clip-composited-descendant.html |
| index eea249b00af35070b808f5a7266d63b851787f54..05af9686f25e90b45be1f9b518055b75ca102aad 100644 |
| --- a/LayoutTests/compositing/squashing/repaint-child-of-squashed.html |
| +++ b/LayoutTests/compositing/squashing/clip-composited-descendant.html |
| @@ -13,27 +13,36 @@ |
| .behind { |
| position: absolute; |
| - z-index: 1; |
| + z-index: 0; |
| top: 50px; |
| left: 50px; |
| background-color: blue; |
| } |
| -.top { |
| +.middle { |
| position: absolute; |
| z-index: 1; |
| + top: 20px; |
| + left: 100px; |
| + background-color: cyan; |
| +} |
| + |
| +.top { |
| + position: absolute; |
| + z-index: 2; |
| top: 130px; |
| left: 130px; |
| background-color: cyan; |
| + /*overflow:hidden;*/ |
|
abarth-chromium
2014/04/28 23:29:57
Remove commented out code?
chrishtr
2014/04/28 23:31:30
Done.
|
| } |
| -#inner { |
| +.inner { |
| position:absolute; |
| top:10px; |
| left: 10px; |
| height: 50px; width: 50px; |
| background-color: lightslategray; |
| - z-index: 2 |
| + z-index: 3; |
| } |
| </style> |
| @@ -52,16 +61,11 @@ |
| function executeTestCases() |
| { |
| - window.internals.startTrackingRepaints(document); |
| - document.getElementById('Case1').textContent = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_REPAINT_RECTS); |
| - window.internals.stopTrackingRepaints(document); |
| + document.getElementById('Case1').textContent = window.internals.layerTreeAsText(document); |
| - window.internals.startTrackingRepaints(document); |
| - document.querySelector("#inner").style.backgroundColor = 'red'; |
| - document.getElementById('Case2').textContent = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_REPAINT_RECTS); |
| - window.internals.stopTrackingRepaints(document); |
| + document.querySelector("#top").style.overflow = 'hidden'; |
| + document.getElementById('Case2').textContent = window.internals.layerTreeAsText(document); |
| - // Display the test results only after test is done so that it does not affect repaint rect results. |
| document.getElementById('testResults').style.display = "block"; |
| if (window.testRunner) |
| @@ -72,8 +76,11 @@ |
| <body onload="runTest()"> |
| <div class="composited box behind"></div> |
| - <div class="box top"> |
| - <div id="inner"> |
| + <div class="box middle"> |
| + </div> |
| + |
| + <div id="top" class="box top"> |
| + <div class="inner"> |
| </div> |
| </div> |
| @@ -81,7 +88,7 @@ |
| CASE 1, original layer tree |
| <pre id="Case1"></pre> |
| - CASE 2, change color of "inner" to red |
| + CASE 2, layer tree with overflow:hidden on the parent of a composited box. Parent is no longer squashed. |
| <pre id="Case2"></pre> |
| </div> |
| </body> |
