Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260113004: Don't squash layers that have a clip or overflow clip. (Closed)

Created:
6 years, 7 months ago by chrishtr
Modified:
6 years, 7 months ago
CC:
blink-reviews, chrishtr, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., ojan, rune+blink
Visibility:
Public.

Description

Don't squash layers that have a clip or overflow clip. Don't squash layers that have a clip or overflow clip, because they may use a composited graphics layer to clip descendant layers. BUG=366101 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172845

Patch Set 1 #

Patch Set 2 : Added test. #

Total comments: 2

Patch Set 3 : Adjusted test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -168 lines) Patch
M LayoutTests/compositing/fixed-position-changed-to-absolute-expected.txt View 1 2 1 chunk +13 lines, -6 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt View 1 2 1 chunk +8 lines, -12 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt View 1 2 2 chunks +16 lines, -3 lines 0 comments Download
M LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt View 1 2 1 chunk +11 lines, -8 lines 0 comments Download
A + LayoutTests/compositing/squashing/clip-composited-descendant.html View 1 2 4 chunks +21 lines, -15 lines 0 comments Download
A + LayoutTests/compositing/squashing/clip-composited-descendant-expected.txt View 1 2 4 chunks +12 lines, -9 lines 0 comments Download
D LayoutTests/virtual/softwarecompositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/virtual/softwarecompositing/layer-creation/overflow-scroll-overlap-expected.txt View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
chrishtr
It seems like clipsCompositingDescendants() is the right fix for this, since that is the condition ...
6 years, 7 months ago (2014-04-28 22:00:44 UTC) #1
chrishtr
6 years, 7 months ago (2014-04-28 23:26:54 UTC) #2
abarth-chromium
LGTM In the future, we should be able to do better here, but you've captured ...
6 years, 7 months ago (2014-04-28 23:29:57 UTC) #3
chrishtr
https://codereview.chromium.org/260113004/diff/20001/LayoutTests/compositing/squashing/clip-composited-descendant.html File LayoutTests/compositing/squashing/clip-composited-descendant.html (right): https://codereview.chromium.org/260113004/diff/20001/LayoutTests/compositing/squashing/clip-composited-descendant.html#newcode36 LayoutTests/compositing/squashing/clip-composited-descendant.html:36: /*overflow:hidden;*/ On 2014/04/28 23:29:57, abarth wrote: > Remove commented ...
6 years, 7 months ago (2014-04-28 23:31:30 UTC) #4
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 7 months ago (2014-04-28 23:31:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/260113004/20001
6 years, 7 months ago (2014-04-28 23:32:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 00:01:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 7 months ago (2014-04-29 00:01:24 UTC) #8
chrishtr
Adjusted a few layout tests that now have fewer squashed layers.
6 years, 7 months ago (2014-04-29 03:41:14 UTC) #9
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 7 months ago (2014-04-29 03:41:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/260113004/40001
6 years, 7 months ago (2014-04-29 03:41:50 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 04:49:14 UTC) #12
Message was sent while issue was closed. 
Change committed as 172845

Powered by Google App Engine
This is Rietveld 408576698