Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2601063002: Blacklisting of method names coming from std library. (Closed)
Patch Set: Also blacklisting "insert". Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
index 4279c1dd0f3e4f37bb58ec06352f678799e7b36b..b75233bdba31760f75066a2a82ea4f6ea2528103 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
@@ -262,6 +262,15 @@ class Foo {
// and should cover both instance and static methods as well as functions.
int hash() const { return 123; }
static int hash(const Foo& x) { return x.hash(); }
+
+ // https://crbug.com672902: std-like names should not be rewritten.
+ void emplace_back(int x) {}
+ void insert(int x) {}
+ void push_back(int x) {}
+ int* back() { return nullptr; }
+ int* front() { return nullptr; }
+ void erase() {}
+ bool empty() { return true; }
};
void begin(int x) {}
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698