ChromeOS MD-OOBE: Add HID detection screen.

chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/login/screens/core_oobe_actor.h"
 #include "chrome/browser/chromeos/login/screens/hid_detection_model.h"
 #include "chrome/browser/ui/webui/chromeos/login/oobe_screen.h"
+#include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/chromeos_switches.h"
 #include "components/login/localized_values_builder.h"
 #include "components/prefs/pref_service.h"
 
 namespace {
 
 const char kJsScreenPath[] = "login.HIDDetectionScreen";
 
@@ skipping 20 matching lines @@
     return;
   }
   core_oobe_actor_->InitDemoModeDetection();
 
   PrefService* local_state = g_browser_process->local_state();
   int num_of_times_dialog_was_shown = local_state->GetInteger(
       prefs::kTimesHIDDialogShown);
   local_state->SetInteger(prefs::kTimesHIDDialogShown,
                           num_of_times_dialog_was_shown + 1);
 
+  // useMdOobe must be updated before HID screen is shown.
+  base::DictionaryValue localized_strings;
+  GetOobeUI()->GetLocalizedStrings(&localized_strings);
+  core_oobe_actor_->ReloadContent(localized_strings);

[xiyuan, 2017/01/04 21:02:23]

Why do we need to do this again? Wouldn't 'newOobeUI' be set in OobeUI's ctor?

[Alexander Alekseev, 2017/01/04 21:14:19]

This was an attempt to create DOM objects. It actually doesn't work, so I added
checks for existence of dom-objects everywhere.

[xiyuan, 2017/01/05 00:09:06]

Can you clarify? What does not work? What happens if we remove this? MD hid
screen would not show up?

[Alexander Alekseev, 2017/01/05 02:01:16]

Sorry, my comment was about a different code snippet.

This code is correct. useMdOobe flag is set in strings.
Now it is false by default, but after OOBE screens are initialized, it might be
set to true.

When OOBE "network" screen is displayed, it has language selection code, so
strings are reloaded when it is displayed.

But "HID detection" screen can be shown before "network" screen, so all strings
are in their "initial" values and "useMDOobe" flag is false. So this code
updates strings after all screens were initialized.

[xiyuan, 2017/01/05 17:25:07]

emm, this feels hacky.

Imaging we have another screen precedes network screen that needs to have a MD
version (e.g. WrongHWIDScreen, or ), then we need to do the same hack there too.

We should probably move the ReloadContent call into
WizardController::SetShowMdOobe and call it when the pref value changes. Or have
a better way to pass useMDOobe flag instead of using loadTimeData.

[Alexander Alekseev, 2017/01/11 20:04:49]

I implemented UpdateLocalizedStringsIfNeeded().

+
   ShowScreen(OobeScreen::SCREEN_OOBE_HID_DETECTION);
 }
 
 void HIDDetectionScreenHandler::Hide() {
 }
 
 void HIDDetectionScreenHandler::Bind(HIDDetectionModel& model) {
   model_ = &model;
   BaseScreenHandler::SetBaseScreen(model_);
   if (page_is_ready())
@@ skipping 48 matching lines @@
   if (model_)
     model_->OnContinueButtonClicked();
 }
 
 // static
 void HIDDetectionScreenHandler::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterIntegerPref(prefs::kTimesHIDDialogShown, 0);
 }
 
 }  // namespace chromeos