third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2600903002: Paint the whole of a table-part background image behind the cells in a table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2600903002: Paint the whole of a table-part background image behind the cells in a table (Closed)

Patch Set: Paint the whole of an image behind the cells in a table Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 2e69829b2ac331b700c38b47eeb98faa02bf4815..d52105a018d99823b864a002df77b28e812ee7df 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -1498,7 +1498,7 @@ bool LayoutBox::getBackgroundPaintedExtent(LayoutRect& paintedExtent) const {

// TODO(jchaffraix): This function should be rethought as it's called during

// and outside of the paint phase. Potentially returning different results at

// different phases.

- geometry.calculate(*this, nullptr, GlobalPaintNormalPhase,

+ geometry.calculate(*this, nullptr, nullptr, GlobalPaintNormalPhase,

style()->backgroundLayers(), backgroundRect);

if (geometry.hasNonLocalGeometry())

return false;