Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: src/objects.h

Issue 260083011: Return MaybeHandle from Object::ToSmi. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 0ce8f977c758efd981456abf558411363567a731..b1219e9a681159cd24335ae61465c0a8ce58bc82 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1490,9 +1490,8 @@ class Object : public MaybeObject {
Handle<Context> context);
// Converts this to a Smi if possible.
- // Failure is returned otherwise.
- static MUST_USE_RESULT inline Handle<Object> ToSmi(Isolate* isolate,
- Handle<Object> object);
+ static MUST_USE_RESULT inline MaybeHandle<Smi> ToSmi(Isolate* isolate,
+ Handle<Object> object);
void Lookup(Name* name, LookupResult* result);
« no previous file with comments | « src/ic.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698