chrome/common/extensions/api/networking_private.json - Issue 260083007: Replace chrome://network implementation with networkConfig API

Unified Diff: chrome/common/extensions/api/networking_private.json

Issue 260083007: Replace chrome://network implementation with networkConfig API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Feedback Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/network/network_config.js ('K') | « chrome/chrome_browser_ui.gypi ('k') | chromeos/network/network_state.cc » ('j') | chromeos/network/onc/onc_translator_shill_to_onc.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/networking_private.json

diff --git a/chrome/common/extensions/api/networking_private.json b/chrome/common/extensions/api/networking_private.json

index b9f66e8b7381bc812c98c05548c972d2eb30f519..e34a430c2fd716702f867b127fb5df201ae590b9 100644

--- a/chrome/common/extensions/api/networking_private.json

+++ b/chrome/common/extensions/api/networking_private.json

@@ -113,7 +113,7 @@

{

"name": "getState",

- "description": "Gets the cached read-only properties of the network with id networkGuid. This is meant to be a higher performance function than getProperties, which requires a round trip to query the networking subsystem. It only returns a subset of the properties returned by getProperties.",

+ "description": "Gets the cached read-only properties of the network with id networkGuid. This is meant to be a higher performance function than getProperties, which requires a round trip to query the networking subsystem. It returns a subset of the properties returned by getProperties (see 'proerties')",

pneubeck (no reviews) 2014/05/08 09:21:43 nit: proerties -> properties

"parameters": [

{

"name": "networkGuid",

@@ -127,7 +127,7 @@

{

"name": "properties",

"$ref": "NetworkProperties",

- "description": "Results of the query for network properties."

+ "description": "Result of the query for network properties. Includes the following values: GUID, Type, Name, ConnectionState, ErrorState, WiFi.Security, WiFi.SignalStrength, Cellular.NetworkTechnology, Cellular.ActivationState, Cellular.RoamingState. Cellular.OutOfCredits"

pneubeck (no reviews) 2014/05/08 09:21:43 nit: RoamingState. -> RoamingState, ( . vs. ,

}

]

}

@@ -206,7 +206,7 @@

{

"name": "getEnabledNetworkTypes",

- "description": "Returns a list of the enabled network type.",

+ "description": "Returns a list of the enabled network types.",

"parameters": [

{

"name": "callback",

@@ -214,7 +214,7 @@

"optional": true,

"parameters": [

{

- "name": "networkList",

+ "name": "enabledTypes",

"type": "array",

"items": { "$ref": "NetworkType" }

}

@@ -410,7 +410,7 @@

{

"name": "getCaptivePortalStatus",

- "description": "Returns captive portal status for the network with networkGuid.",

+ "description": "Returns captive portal status for the network with networkPath.",

pneubeck (no reviews) 2014/05/08 09:21:43 hm. shouldn't this and the first parameter be 'net

"parameters": [

{

"name": "networkPath",