Replace chrome://network implementation with networkConfig API

chrome/browser/ui/webui/chromeos/network_config_message_handler.h

Index: chrome/browser/ui/webui/chromeos/network_config_message_handler.h
diff --git a/chrome/browser/ui/webui/chromeos/network_config_message_handler.h b/chrome/browser/ui/webui/chromeos/network_config_message_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..cc74a030b061461205be70cbe7f5f2ec6a074b7f
--- /dev/null
+++ b/chrome/browser/ui/webui/chromeos/network_config_message_handler.h
@@ -0,0 +1,37 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_NETWORK_CONFIG_MESSAGE_HANDLER_H_
+#define CHROME_BROWSER_UI_WEBUI_CHROMEOS_NETWORK_CONFIG_MESSAGE_HANDLER_H_
+
+#include "content/public/browser/web_ui_message_handler.h"
+
+namespace base {
+class ListValue;
+}
+
+namespace chromeos {
+
+// This class provides support for network configuration from WebUI components.
+// It implements network_config.js which is a drop-in replacement for the
+// networkingPrivate extention API. TODO(stevenjb): Implement the remaining
+// networkingPrivate methods as needed.

[armansito, 2014/04/29 21:26:45]

what's the reason for having a class that emulates networkingPrivate methods?
For testing?

[stevenjb, 2014/04/29 21:44:03]

The long term goal is to move all Settings to one or more component extensions.
During the long transition, we want to develop Settings UI code that can be
integrated into other apps (e.g. Kiosk apps) to allow some level of network
configuration UI without running Chrome.
This class provides that transition layer. The idea is that the JS code can be
copied, with the simple addition of 'networkConfig = chrome.networkingPrivate'.
See
https://docs.google.com/a/google.com/document/d/1EmDW5a-tayNoGeinBO0dmXSnabNX...
for more details.

[armansito, 2014/04/29 22:54:47]

I see. So the idea is for the two hooks (the networkingPrivate API
implementation and network_config.js) to use the same backend (i.e.
NetworkHandler)? I'm not super familiar with the networkingPrivate
implementation but it seems to me that the two APIs can pretty much share their
entire C++ back end. Sorry if this doesn't make sense, I'm just trying to make
sense of it.

+class NetworkConfigMessageHandler : public content::WebUIMessageHandler {
+ public:
+  NetworkConfigMessageHandler();
+  virtual ~NetworkConfigMessageHandler();
+
+  // WebUIMessageHandler implementation.
+  virtual void RegisterMessages() OVERRIDE;
+
+ private:
+  void GetVisibleNetworks(const base::ListValue* value) const;
+  void GetFavoriteNetworks(const base::ListValue* value) const;
+
+  DISALLOW_COPY_AND_ASSIGN(NetworkConfigMessageHandler);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_UI_WEBUI_CHROMEOS_NETWORK_CONFIG_MESSAGE_HANDLER_H_