Replace chrome://network implementation with networkConfig API

chromeos/network/network_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_util.h"
 
 #include "base/strings/string_tokenizer.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "chromeos/network/favorite_state.h"
@@ skipping 149 matching lines @@
   scoped_ptr<base::DictionaryValue> onc_dictionary =
       TranslateShillServiceToONCPart(
           shill_dictionary, &onc::kNetworkWithStateSignature);
   return onc_dictionary.Pass();
 }
 
 scoped_ptr<base::ListValue> TranslateNetworkListToONC(
     NetworkTypePattern pattern,
     bool configured_only,
     bool visible_only,
-    int limit) {
+    int limit,
+    bool debugging_properties) {
   NetworkStateHandler::FavoriteStateList favorite_states;
   NetworkHandler::Get()->network_state_handler()->GetFavoriteListByType(
       pattern, configured_only, visible_only, limit, &favorite_states);
 
   scoped_ptr<base::ListValue> network_properties_list(new base::ListValue);
   for (NetworkStateHandler::FavoriteStateList::iterator it =
            favorite_states.begin();
        it != favorite_states.end();
        ++it) {
     scoped_ptr<base::DictionaryValue> onc_dictionary =
         TranslateFavoriteStateToONC(*it);
+
+    if (debugging_properties) {
+      onc_dictionary->SetString("profile_path", (*it)->profile_path());

[pneubeck (no reviews), 2014/05/22 16:24:20]

SetString -> SetStringWithoutPathExpansion

maybe I should really start an effort to rename that damn function :-)

[stevenjb, 2014/05/23 21:50:59]

So, when using a literal, I've not been bothering with the verbose form, since
there's obviously nothing to expand.

+      std::string onc_source = (*it)->ui_data().GetONCSourceAsString();
+      if (!onc_source.empty())
+        onc_dictionary->SetString("onc_source", onc_source);

[pneubeck (no reviews), 2014/05/22 16:24:20]

In network_ui.js you use "OncSource", maybe out of sync?

[stevenjb, 2014/05/23 21:50:59]

Done.

+    }
+
     network_properties_list->Append(onc_dictionary.release());
   }
   return network_properties_list.Pass();
 }
 
 }  // namespace network_util
 }  // namespace chromeos