third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html - Issue 2600733002: Convert budget LayoutTests to use promise_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

Issue 2600733002: Convert budget LayoutTests to use promise_test. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html ('K') | « third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html b/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

index e8112b0276e348f4e4dca0eb564efa822a552d54..2a109284a7ab720871b7e7e45e414172282e272f 100644

--- a/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

+++ b/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html

@@ -11,17 +11,16 @@

</head>

<body>

- async_test(function(test) {

- var script = 'resources/instrumentation-service-worker.js';

- var scope = 'resources/scope/' + location.pathname;

- var port;

+ promise_test(function(test) {

+ const script = 'resources/instrumentation-service-worker.js';

+ const scope = 'resources/scope/' + location.pathname;

+ let port;

- budgetServiceMock.then(mock => {

+ return budgetServiceMock.then(mock => {

mock.setReserveSuccess(true);

- getActiveServiceWorkerWithMessagePort(test, script, scope)

+ return getActiveServiceWorkerWithMessagePort(test, script, scope)

.then(function(workerInfo) {

port = workerInfo.port;

- port.postMessage({ command: 'reserve' });

port.addEventListener('message', function(event) {

if (typeof event.data != 'object' || !event.data.command)

@@ -30,8 +29,9 @@

assert_equals(event.data.command, 'reserve');

assert_true(event.data.success,

'reserve should succeed. Error message: ' + event.data.errorMessage);

- test.done();

});

+ return sendCommand(port, { command: 'reserve' });

})

.catch(unreached_rejection(test));

});