Do not cache the result of RenderStyle::computedLineHeight()

Source/core/rendering/RenderBR.cpp

 /**
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 17 matching lines @@
 namespace WebCore {
 
 static PassRefPtr<StringImpl> newlineString()
 {
     DEFINE_STATIC_LOCAL(const String, string, ("\n"));
     return string.impl();
 }
 
 RenderBR::RenderBR(Node* node)
     : RenderText(node, newlineString())
-    , m_lineHeight(-1)
 {
 }
 
 RenderBR::~RenderBR()
 {
 }
 
 int RenderBR::lineHeight(bool firstLine) const
 {
-    if (firstLine && document().styleEngine()->usesFirstLineRules()) {
-        RenderStyle* s = style(firstLine);
-        if (s != style())
-            return s->computedLineHeight();
-    }
-
-    if (m_lineHeight == -1)
-        m_lineHeight = style()->computedLineHeight();
-
-    return m_lineHeight;
+    RenderStyle* s = style(firstLine && document().styleEngine()->usesFirstLineRules());
+    return s->computedLineHeight();
 }
 
 void RenderBR::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
 {
     RenderText::styleDidChange(diff, oldStyle);
-    m_lineHeight = -1;
 }
 
 int RenderBR::caretMinOffset() const
 {
     return 0;
 }
 
 int RenderBR::caretMaxOffset() const
 {
     return 1;
 }
 
 PositionWithAffinity RenderBR::positionForPoint(const LayoutPoint&)
 {
     return createPositionWithAffinity(0, DOWNSTREAM);
 }
 
 } // namespace WebCore