Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 2600713002: Add MSA optimized RAW/RGB/ARGB to ARGB/Y/UV row functions (Closed)

Created:
3 years, 12 months ago by manojkumar.bhosale
Modified:
3 years, 11 months ago
Reviewers:
fbarchard1
CC:
gordana.cmiljanovic_imgtec.com, raghu.gandham_imgtec.com, parag.salasakar_imgtec.com, mandar.sahastrabuddhe_imgtec.com, rob.isherwood_imgtec.com
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add MSA optimized RAW/RGB/ARGB to ARGB/Y/UV row functions R=fbarchard@google.com BUG=libyuv:634 Performance Gain (vs C vectorized) ARGB1555ToARGBRow_MSA - 1.85 ARGB1555ToARGBRow_Any_MSA - 1.82 RGB565ToARGBRow_MSA - 2.14 RGB565ToARGBRow_Any_MSA - 2.08 RGB24ToARGBRow_MSA - 8.57 RGB24ToARGBRow_Any_MSA - 7.42 RAWToARGBRow_MSA - 8.57 RAWToARGBRow_Any_MSA - 7.42 ARGB1555ToYRow_MSA - 2.60 ARGB1555ToYRow_Any_MSA - 2.47 RGB565ToYRow_MSA - 2.45 RGB565ToYRow_Any_MSA - 2.33 RGB24ToYRow_MSA - 2.23 RGB24ToYRow_Any_MSA - 2.01 RAWToYRow_MSA - 2.25 RAWToYRow_Any_MSA - 2.02 ARGB1555ToUVRow_MSA - 1.40 ARGB1555ToUVRow_Any_MSA - 1.37 RGB565ToUVRow_MSA - 1.68 RGB565ToUVRow_Any_MSA - 1.63 RGB24ToUVRow_MSA - 3.02 RGB24ToUVRow_Any_MSA - 2.87 RAWToUVRow_MSA - 3.04 RAWToUVRow_Any_MSA - 2.85 Performance Gain (vs C non-vectorized) ARGB1555ToARGBRow_MSA - 4.66 ARGB1555ToARGBRow_Any_MSA - 4.45 RGB565ToARGBRow_MSA - 5.58 RGB565ToARGBRow_Any_MSA - 5.34 RGB24ToARGBRow_MSA - 8.57 RGB24ToARGBRow_Any_MSA - 7.42 RAWToARGBRow_MSA - 8.57 RAWToARGBRow_Any_MSA - 7.42 ARGB1555ToYRow_MSA - 6.38 ARGB1555ToYRow_Any_MSA - 5.98 RGB565ToYRow_MSA - 6.42 RGB565ToYRow_Any_MSA - 6.05 RGB24ToYRow_MSA - 7.87 RGB24ToYRow_Any_MSA - 7.01 RAWToYRow_MSA - 7.98 RAWToYRow_Any_MSA - 7.01 ARGB1555ToUVRow_MSA - 5.39 ARGB1555ToUVRow_Any_MSA - 5.06 RGB565ToUVRow_MSA - 6.39 RGB565ToUVRow_Any_MSA - 5.90 RGB24ToUVRow_MSA - 3.04 RGB24ToUVRow_Any_MSA - 2.87 RAWToUVRow_MSA - 3.04 RAWToUVRow_Any_MSA - 2.88 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/7c64163ff479ec4cdadbcbcf67397080d59117ef

Patch Set 1 #

Total comments: 4

Patch Set 2 : Resolved merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1026 lines, -134 lines) Patch
M include/libyuv/row.h View 1 7 chunks +74 lines, -0 lines 0 comments Download
M source/convert.cc View 1 20 chunks +166 lines, -134 lines 0 comments Download
M source/convert_argb.cc View 1 4 chunks +32 lines, -0 lines 0 comments Download
M source/row_any.cc View 1 3 chunks +36 lines, -0 lines 0 comments Download
M source/row_msa.cc View 1 chunk +718 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
manojkumar.bhosale
3 years, 12 months ago (2016-12-23 11:02:16 UTC) #1
manojkumar.bhosale
Updated with reviewers, cc list and performance gain numbers
3 years, 11 months ago (2017-01-05 10:06:37 UTC) #3
fbarchard1
lgtm https://codereview.chromium.org/2600713002/diff/1/source/row_msa.cc File source/row_msa.cc (right): https://codereview.chromium.org/2600713002/diff/1/source/row_msa.cc#newcode1516 source/row_msa.cc:1516: v4u32 const_0x810019 = (v4u32)__msa_fill_w(0x810019); caveat these constants subject ...
3 years, 11 months ago (2017-01-11 20:26:31 UTC) #4
manojkumar.bhosale
https://codereview.chromium.org/2600713002/diff/1/source/row_msa.cc File source/row_msa.cc (right): https://codereview.chromium.org/2600713002/diff/1/source/row_msa.cc#newcode1516 source/row_msa.cc:1516: v4u32 const_0x810019 = (v4u32)__msa_fill_w(0x810019); On 2017/01/11 20:26:31, fbarchard1 wrote: ...
3 years, 11 months ago (2017-01-13 08:42:35 UTC) #5
manojkumar.bhosale
3 years, 11 months ago (2017-01-13 08:59:25 UTC) #6
manojkumar.bhosale
3 years, 11 months ago (2017-01-13 08:59:25 UTC) #7
manojkumar.bhosale
3 years, 11 months ago (2017-01-13 10:11:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7c64163ff479ec4cdadbcbcf67397080d59117ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698