Run tools/clang-format-js on some of chrome/browser/resources/

chrome/browser/resources/feedback/js/feedback.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @type {string}
  * @const
  */
 var SRT_DOWNLOAD_PAGE = 'https://www.google.com/chrome/cleanup-tool/';
 
@@ skipping 142 matching lines @@
     var description = $('description-text');
     description.placeholder = loadTimeData.getString('no-description');
     description.focus();
     return false;
   }
 
   // Prevent double clicking from sending additional reports.
   $('send-report-button').disabled = true;
   console.log('Feedback: Sending report');
   if (!feedbackInfo.attachedFile && attachedFileBlob) {
-    feedbackInfo.attachedFile = { name: $('attach-file').value,
-                                  data: attachedFileBlob };
+    feedbackInfo.attachedFile = {
+      name: $('attach-file').value,
+      data: attachedFileBlob
+    };
   }
 
   feedbackInfo.description = $('description-text').value;
   feedbackInfo.pageUrl = $('page-url-text').value;
   feedbackInfo.email = $('user-email-text').value;
 
   var useSystemInfo = false;
   var useHistograms = false;
-  if ($('sys-info-checkbox') != null &&
-      $('sys-info-checkbox').checked) {
+  if ($('sys-info-checkbox') != null && $('sys-info-checkbox').checked) {
     // Send histograms along with system info.
     useSystemInfo = useHistograms = true;
   }
-<if expr="chromeos">
+  // <if expr="chromeos">
   if ($('performance-info-checkbox') == null ||
       !($('performance-info-checkbox').checked)) {
     feedbackInfo.traceId = null;
   }
-</if>
+  // </if>
 
   feedbackInfo.sendHistograms = useHistograms;
 
   // If the user doesn't want to send the screenshot.
   if (!$('screenshot-checkbox').checked)
     feedbackInfo.screenshot = null;
 
   var productId = parseInt('' + feedbackInfo.productId);
   if (isNaN(productId)) {
     // For apps that still use a string value as the |productId|, we must clear
@@ skipping 28 matching lines @@
 function dataUrlToBlob(url) {
   var mimeString = url.split(',')[0].split(':')[1].split(';')[0];
   var data = atob(url.split(',')[1]);
   var dataArray = [];
   for (var i = 0; i < data.length; ++i)
     dataArray.push(data.charCodeAt(i));
 
   return new Blob([new Uint8Array(dataArray)], {type: mimeString});
 }
 
-<if expr="chromeos">
+// <if expr="chromeos">
 /**
  * Update the page when performance feedback state is changed.
  */
 function performanceFeedbackChanged() {
   if ($('performance-info-checkbox').checked) {
     $('attach-file').disabled = true;
     $('attach-file').checked = false;
 
     $('screenshot-checkbox').disabled = true;
     $('screenshot-checkbox').checked = false;
   } else {
     $('attach-file').disabled = false;
     $('screenshot-checkbox').disabled = false;
   }
 }
-</if>
+// </if>
 
 function resizeAppWindow() {
   // We pick the width from the titlebar, which has no margins.
   var width = $('title-bar').scrollWidth;
   if (width < FEEDBACK_MIN_WIDTH)
     width = FEEDBACK_MIN_WIDTH;
 
   // We get the height by adding the titlebar height and the content height +
   // margins. We can't get the margins for the content-pane here by using
   // style.margin - the variable seems to not exist.
-  var height = $('title-bar').scrollHeight +
-      $('content-pane').scrollHeight + CONTENT_MARGIN_HEIGHT;
+  var height = $('title-bar').scrollHeight + $('content-pane').scrollHeight +
+      CONTENT_MARGIN_HEIGHT;
 
   var minHeight = FEEDBACK_MIN_HEIGHT;
   if (feedbackInfo.flow == FeedbackFlow.LOGIN)
     minHeight = FEEDBACK_MIN_HEIGHT_LOGIN;
   height = Math.max(height, minHeight);
 
   chrome.app.window.current().resizeTo(width, height);
 }
 
 /**
@@ skipping 60 matching lines @@
       takeScreenshot(function(screenshotCanvas) {
         // We've taken our screenshot, show the feedback page without any
         // further delay.
         window.webkitRequestAnimationFrame(function() {
           resizeAppWindow();
         });
         chrome.app.window.current().show();
 
         var screenshotDataUrl = screenshotCanvas.toDataURL('image/png');
         $('screenshot-image').src = screenshotDataUrl;
-        $('screenshot-image').classList.toggle('wide-screen',
-            $('screenshot-image').width > MAX_SCREENSHOT_WIDTH);
+        $('screenshot-image')
+            .classList.toggle(
+                'wide-screen',
+                $('screenshot-image').width > MAX_SCREENSHOT_WIDTH);
         feedbackInfo.screenshot = dataUrlToBlob(screenshotDataUrl);
       });
 
       chrome.feedbackPrivate.getUserEmail(function(email) {
         $('user-email-text').value = email;
       });
 
       // Initiate getting the system info.
       isSystemInfoReady = false;
       getSystemInformation(onSystemInformation);
 
       // An extension called us with an attached file.
       if (feedbackInfo.attachedFile) {
         $('attached-filename-text').textContent =
             feedbackInfo.attachedFile.name;
         attachedFileBlob = feedbackInfo.attachedFile.data;
         $('custom-file-container').hidden = false;
         $('attach-file').hidden = true;
       }
 
       // No URL and file attachment for login screen feedback.
       if (feedbackInfo.flow == FeedbackFlow.LOGIN) {
         $('page-url').hidden = true;
         $('attach-file-container').hidden = true;
         $('attach-file-note').hidden = true;
       }
 
-<if expr="chromeos">
+      // <if expr="chromeos">
       if (feedbackInfo.traceId && ($('performance-info-area'))) {
         $('performance-info-area').hidden = false;
         $('performance-info-checkbox').checked = true;
         performanceFeedbackChanged();
         $('performance-info-link').onclick = openSlowTraceWindow;
       }
-</if>
+      // </if>
       chrome.feedbackPrivate.getStrings(function(strings) {
         loadTimeData.data = strings;
         i18nTemplate.process(document, loadTimeData);
 
         if ($('sys-info-url')) {
           // Opens a new window showing the full anonymized system+app
           // information.
           $('sys-info-url').onclick = function() {
             var win = chrome.app.window.get(SYSINFO_WINDOW_ID);
             if (win) {
               win.show();
               return;
             }
             chrome.app.window.create(
-              '/html/sys_info.html', {
-                frame: 'chrome',
-                id: SYSINFO_WINDOW_ID,
-                width: 640,
-                height: 400,
-                hidden: false,
-                resizable: true
-              }, function(appWindow) {
-                // Define functions for the newly created window.
+                '/html/sys_info.html', {
+                  frame: 'chrome',
+                  id: SYSINFO_WINDOW_ID,
+                  width: 640,
+                  height: 400,
+                  hidden: false,
+                  resizable: true
+                },
+                function(appWindow) {
+                  // Define functions for the newly created window.
 
-                // Gets the full system information for the new window.
-                appWindow.contentWindow.getFullSystemInfo =
-                    function(callback) {
-                      if (isSystemInfoReady) {
-                        callback(feedbackInfo.systemInformation);
-                        return;
-                      }
+                  // Gets the full system information for the new window.
+                  appWindow.contentWindow.getFullSystemInfo = function(
+                      callback) {
+                    if (isSystemInfoReady) {
+                      callback(feedbackInfo.systemInformation);
+                      return;
+                    }
 
-                      sysInfoPageOnSysInfoReadyCallback = callback;
-                    };
+                    sysInfoPageOnSysInfoReadyCallback = callback;
+                  };
 
-                // Returns the loadTimeData for the new window.
-                appWindow.contentWindow.getLoadTimeData = function() {
-                  return loadTimeData;
-                };
-            });
+                  // Returns the loadTimeData for the new window.
+                  appWindow.contentWindow.getLoadTimeData = function() {
+                    return loadTimeData;
+                  };
+                });
           };
         }
         if ($('histograms-url')) {
           // Opens a new window showing the histogram metrics.
           $('histograms-url').onclick =
               windowOpener(STATS_WINDOW_ID, 'chrome://histograms');
         }
         // Make sure our focus starts on the description field.
         $('description-text').focus();
       });
     }
   });
 
   window.addEventListener('DOMContentLoaded', function() {
     // Ready to receive the feedback object.
     chrome.runtime.sendMessage({ready: true});
 
     // Setup our event handlers.
     $('attach-file').addEventListener('change', onFileSelected);
     $('send-report-button').onclick = sendReport;
     $('cancel-button').onclick = cancel;
     $('remove-attached-file').onclick = clearAttachedFile;
-<if expr="chromeos">
-    $('performance-info-checkbox').addEventListener(
-        'change', performanceFeedbackChanged);
-</if>
+    // <if expr="chromeos">

[dschuyler, 2016/12/28 23:59:12]

Just pointing this out in case it hadn't been noticed. The <if> is being
indented with the code now. I'm good with this (in favor of it actually), but I
suspect someone will dislike it.

[Dan Beam, 2016/12/29 00:02:05]

we're probably gonna have to change these to cr.isChromeOS anyways as they're
breaking something (the feedback page on the try bots)

+    $('performance-info-checkbox')
+        .addEventListener('change', performanceFeedbackChanged);
+    // </if>
   });
 }
 
 initialize();