Adding retry logic for applying desktop resolution changes to RDP session.

remoting/host/win/rdp_client_window.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_WIN_RDP_HOST_WINDOW_H_
 #define REMOTING_HOST_WIN_RDP_HOST_WINDOW_H_
 
 #include <atlbase.h>
 #include <atlcom.h>
 #include <atlcrack.h>
 #include <atlctl.h>
 
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
+#include "base/timer/timer.h"
 #include "base/win/scoped_comptr.h"
 #include "net/base/ip_endpoint.h"
 #include "remoting/host/screen_resolution.h"
 // The following header was generated by Visual Studio. We had to check it in
 // due to a bug in VS2013. See crbug.com/318952 for details.
 #include "remoting/host/win/com_imported_mstscax.tlh"
 #include "third_party/webrtc/modules/desktop_capture/desktop_geometry.h"
 
 namespace remoting {
 
@@ skipping 103 matching lines @@
   STDMETHOD(OnAuthenticationWarningDismissed)();
   STDMETHOD(OnConnected)();
   STDMETHOD(OnLoginComplete)();
   STDMETHOD(OnDisconnected)(long reason);
   STDMETHOD(OnFatalError)(long error_code);
   STDMETHOD(OnConfirmClose)(VARIANT_BOOL* allow_close);
 
   int LogOnCreateError(HRESULT error);
 
   // Wrappers for the event handler's methods that make sure that
-  // OnDisconnected() is the last notification delivered and is delevered
+  // OnDisconnected() is the last notification delivered and is delivered
   // only once.
   void NotifyConnected();
   void NotifyDisconnected();
 
   // Updates the desktop using |screen_resolution_| if resizing is supported.
-  void UpdateDesktopResolution();
+  HRESULT UpdateDesktopResolution();
+
+  // Attempts to reapply the requested screen resolution.  This method is used
+  // to workaround the inconsistent behavior seen by the RDP API which can fail
+  // for an indeterminate amount of time (i.e. a few seconds) after the user has
+  // logged into the session.  In practice retrying after ~100ms will succeed,
+  // but we will use |apply_resolution_timer_| to try a few times if the machine
+  // is under load.
+  void ReapplyDesktopResolution();
 
   // Invoked to report connect/disconnect events.
   EventHandler* event_handler_;
 
   // Contains the requested dimensions of the screen.
   remoting::ScreenResolution screen_resolution_;
 
+  // Used for applying resolution changes after a timeout.
+  base::RepeatingTimer apply_resolution_timer_;
+
+  // Tracks the number of resolution change retries.
+  int apply_resolution_attempts_ = 0;
+
   // The endpoint to connect to.
   net::IPEndPoint server_endpoint_;
 
   // The terminal ID assigned to this connection.
   std::string terminal_id_;
 
   // Our RDP session always starts logged out (i.e. at the logon screen), some
   // functions do not work until the user has logged in so we want to track that
   // event.  We don't support logging out so this value should never revert from
   // true to false.
   bool user_logged_in_ = false;
 
   // Interfaces exposed by the RDP ActiveX control.
   base::win::ScopedComPtr<mstsc::IMsRdpClient> client_;
   base::win::ScopedComPtr<mstsc::IMsRdpClient9> client_9_;
   base::win::ScopedComPtr<mstsc::IMsRdpClientAdvancedSettings> client_settings_;
 
   // Used to cancel modal dialog boxes shown by the RDP control.
   class WindowHook;
   scoped_refptr<WindowHook> window_activate_hook_;
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_WIN_RDP_HOST_WINDOW_H_