Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: src/platform-posix.cc

Issue 26006004: Annotate V8 for MemorySanitizer. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/msan.h ('K') | « src/msan.h ('k') | src/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform-posix.cc
===================================================================
--- src/platform-posix.cc (revision 17104)
+++ src/platform-posix.cc (working copy)
@@ -68,6 +68,7 @@
#include "codegen.h"
#include "isolate-inl.h"
+#include "msan.h"
danno 2013/10/10 14:18:07 Here and elsewhere: None of these includes should
Evgeniy Stepanov 2013/10/10 15:08:54 But msan.h is in fact the place where things like
#include "platform.h"
namespace v8 {
@@ -207,6 +208,11 @@
// See http://code.google.com/p/nativeclient/issues/3341
return NULL;
#endif
+#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER) || \
danno 2013/10/10 14:18:07 This change been landed separately, why is this in
Evgeniy Stepanov 2013/10/10 15:08:54 That was in a different repository, I think.
+ defined(THREAD_SANITIZER)
+ // Dynamic tools do not support custom mmap addresses.
+ return NULL;
+#endif
Isolate* isolate = Isolate::UncheckedCurrent();
// Note that the current isolate isn't set up in a call path via
// CpuFeatures::Probe. We don't care about randomization in this case because
« src/msan.h ('K') | « src/msan.h ('k') | src/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698