Annotate V8 for MemorySanitizer.

src/platform-posix.cc

Index: src/platform-posix.cc
===================================================================
--- src/platform-posix.cc	(revision 17104)
+++ src/platform-posix.cc	(working copy)
@@ -68,6 +68,7 @@
 
 #include "codegen.h"
 #include "isolate-inl.h"
+#include "msan.h"

[danno, 2013/10/10 14:18:07]

Here and elsewhere: None of these includes should be hard wired (they should be
conditionally included based on whether MEMORY_SANITIZER is active). 

[Evgeniy Stepanov, 2013/10/10 15:08:54]

But msan.h is in fact the place where things like MSAN_RUNTIME_FUNCTION are
defined in different ways depending on MEMORY_SANITIZER. If we include it
conditionally, then all uses of those annotations would also need to be
surrounded by #ifdef MEMORY_SANITIZER.

 #include "platform.h"
 
 namespace v8 {
@@ -207,6 +208,11 @@
   // See http://code.google.com/p/nativeclient/issues/3341
   return NULL;
 #endif
+#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER) || \

[danno, 2013/10/10 14:18:07]

This change been landed separately, why is this in this CL?

[Evgeniy Stepanov, 2013/10/10 15:08:54]

That was in a different repository, I think.

+    defined(THREAD_SANITIZER)
+  // Dynamic tools do not support custom mmap addresses.
+  return NULL;
+#endif
   Isolate* isolate = Isolate::UncheckedCurrent();
   // Note that the current isolate isn't set up in a call path via
   // CpuFeatures::Probe. We don't care about randomization in this case because