Annotate V8 for MemorySanitizer.

src/platform-posix.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 50 matching lines @@
 
 #if defined(ANDROID) && !defined(V8_ANDROID_LOG_STDOUT)
 #define LOG_TAG "v8"
 #include <android/log.h>
 #endif
 
 #include "v8.h"
 
 #include "codegen.h"
 #include "isolate-inl.h"
+#include "msan.h"

[danno, 2013/10/10 14:18:07]

Here and elsewhere: None of these includes should be hard wired (they should be
conditionally included based on whether MEMORY_SANITIZER is active). 

[Evgeniy Stepanov, 2013/10/10 15:08:54]

But msan.h is in fact the place where things like MSAN_RUNTIME_FUNCTION are
defined in different ways depending on MEMORY_SANITIZER. If we include it
conditionally, then all uses of those annotations would also need to be
surrounded by #ifdef MEMORY_SANITIZER.

 #include "platform.h"
 
 namespace v8 {
 namespace internal {
 
 // 0 is never a valid thread id.
 static const pthread_t kNoThread = (pthread_t) 0;
 
 
 uint64_t OS::CpuFeaturesImpliedByPlatform() {
@@ skipping 119 matching lines @@
 }
 
 
 void* OS::GetRandomMmapAddr() {
 #if defined(__native_client__)
   // TODO(bradchen): restore randomization once Native Client gets
   // smarter about using mmap address hints.
   // See http://code.google.com/p/nativeclient/issues/3341
   return NULL;
 #endif
+#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER) || \

[danno, 2013/10/10 14:18:07]

This change been landed separately, why is this in this CL?

[Evgeniy Stepanov, 2013/10/10 15:08:54]

That was in a different repository, I think.

+    defined(THREAD_SANITIZER)
+  // Dynamic tools do not support custom mmap addresses.
+  return NULL;
+#endif
   Isolate* isolate = Isolate::UncheckedCurrent();
   // Note that the current isolate isn't set up in a call path via
   // CpuFeatures::Probe. We don't care about randomization in this case because
   // the code page is immediately freed.
   if (isolate != NULL) {
     uintptr_t raw_addr;
     isolate->random_number_generator()->NextBytes(&raw_addr, sizeof(raw_addr));
 #if V8_TARGET_ARCH_X64
     // Currently available CPUs have 48 bits of virtual addressing.  Truncate
     // the hint address to 46 bits to give the kernel a fighting chance of
@@ skipping 551 matching lines @@
 
 void Thread::SetThreadLocal(LocalStorageKey key, void* value) {
   pthread_key_t pthread_key = LocalKeyToPthreadKey(key);
   int result = pthread_setspecific(pthread_key, value);
   ASSERT_EQ(0, result);
   USE(result);
 }
 
 
 } }  // namespace v8::internal