Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 26006002: [MIPS] Fix library order and includes for breakpad test (Closed)

Created:
7 years, 2 months ago by petarj
Modified:
7 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[MIPS] Fix library order and includes for breakpad test Add missing header location for linux_dumper_unittest_helper for Android. It is required to correctly locate sgidefs.h. In addition, this change removes duplicate '-ldl', since the order of listed libraries is important for GNU ld (still used for some architectures such as MIPS). BUG= fail to build breakpad tests for MIPS TEST= build breakpad tests MIPS-Android

Patch Set 1 #

Patch Set 2 : Upload again. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M breakpad/breakpad.gyp View 2 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
petarj
PTAL.
7 years, 2 months ago (2013-10-04 15:36:26 UTC) #1
Mark Mentovai
LGTM
7 years, 2 months ago (2013-10-04 16:02:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/26006002/1
7 years, 2 months ago (2013-10-04 16:06:05 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-04 16:11:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/26006002/36001
7 years, 2 months ago (2013-10-04 16:28:40 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 19:31:46 UTC) #6
Message was sent while issue was closed.
Change committed as 227052

Powered by Google App Engine
This is Rietveld 408576698