Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2600593002: Fix touch event flag may not be updated correctly by transform which causes no layout (Closed)
Patch Set: Update the logic to focus on non-passive touchEvents Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index 833dd7e51505056c4ac95379d51e5bbcc2a97643..705ec01948bcc73052547dbbe8ef03a592c5f73b 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -128,6 +128,14 @@ void ScrollingCoordinator::notifyGeometryChanged() {
m_shouldScrollOnMainThreadDirty = true;
}
+void ScrollingCoordinator::checkTransformChangedDueToTouchEvent(
+ const PaintLayer* layer) {
+ if (layer->enclosingNode()->hasBlockingEventListeners(
+ EventTypeNames::touchstart) ||
+ layer->enclosingNode()->hasBlockingEventListeners(
+ EventTypeNames::touchmove))
majidvp 2017/01/04 16:48:51 After some more thinking I don't think this optimi
yigu 2017/01/05 14:05:43 As we discussed, we now optimize by walking up the
+ m_touchEventTargetRectsAreDirty = true;
+}
void ScrollingCoordinator::notifyOverflowUpdated() {
m_scrollGestureRegionIsDirty = true;
}

Powered by Google App Engine
This is Rietveld 408576698