Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2600593002: Fix touch event flag may not be updated correctly by transform which causes no layout (Closed)
Patch Set: Update the logic to focus on non-passive touchEvents Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
411 clipper().clearClipRectsIncludingDescendants(AbsoluteClipRects); 411 clipper().clearClipRectsIncludingDescendants(AbsoluteClipRects);
412 } 412 }
413 413
414 updateTransformationMatrix(); 414 updateTransformationMatrix();
415 415
416 if (had3DTransform != has3DTransform()) 416 if (had3DTransform != has3DTransform())
417 markAncestorChainForDescendantDependentFlagsUpdate(); 417 markAncestorChainForDescendantDependentFlagsUpdate();
418 418
419 if (FrameView* frameView = layoutObject()->document().view()) 419 if (FrameView* frameView = layoutObject()->document().view())
420 frameView->setNeedsUpdateWidgetGeometries(); 420 frameView->setNeedsUpdateWidgetGeometries();
421
422 if (ScrollingCoordinator* scrollingCoordinator =
423 layoutObject()->frame()->page()->scrollingCoordinator())
424 scrollingCoordinator->checkTransformChangedDueToTouchEvent(this);
majidvp 2017/01/04 16:48:51 Is t really enough to notify ScrollingCoordinator
yigu 2017/01/05 14:05:43 As we discussed, this part of logic has been moved
421 } 425 }
422 426
423 static PaintLayer* enclosingLayerForContainingBlock(PaintLayer* layer) { 427 static PaintLayer* enclosingLayerForContainingBlock(PaintLayer* layer) {
424 if (LayoutObject* containingBlock = layer->layoutObject()->containingBlock()) 428 if (LayoutObject* containingBlock = layer->layoutObject()->containingBlock())
425 return containingBlock->enclosingLayer(); 429 return containingBlock->enclosingLayer();
426 return 0; 430 return 0;
427 } 431 }
428 432
429 static const PaintLayer* enclosingLayerForContainingBlock( 433 static const PaintLayer* enclosingLayerForContainingBlock(
430 const PaintLayer* layer) { 434 const PaintLayer* layer) {
(...skipping 2808 matching lines...) Expand 10 before | Expand all | Expand 10 after
3239 } 3243 }
3240 3244
3241 void showLayerTree(const blink::LayoutObject* layoutObject) { 3245 void showLayerTree(const blink::LayoutObject* layoutObject) {
3242 if (!layoutObject) { 3246 if (!layoutObject) {
3243 LOG(INFO) << "Cannot showLayerTree. Root is (nil)"; 3247 LOG(INFO) << "Cannot showLayerTree. Root is (nil)";
3244 return; 3248 return;
3245 } 3249 }
3246 showLayerTree(layoutObject->enclosingLayer()); 3250 showLayerTree(layoutObject->enclosingLayer());
3247 } 3251 }
3248 #endif 3252 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698