Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: components/sessions/core/base_session_service.h

Issue 2600583002: Remove ScopedVector from components/sessions. (Closed)
Patch Set: include Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/core/base_session_service.h
diff --git a/components/sessions/core/base_session_service.h b/components/sessions/core/base_session_service.h
index 610a0c31a8771466856c48534419bb53bfc700a5..473b75d668545567fe5e2d8ccae383c52cb33ae2 100644
--- a/components/sessions/core/base_session_service.h
+++ b/components/sessions/core/base_session_service.h
@@ -10,7 +10,6 @@
#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/macros.h"
-#include "base/memory/scoped_vector.h"
#include "base/memory/weak_ptr.h"
#include "base/task/cancelable_task_tracker.h"
#include "components/sessions/core/sessions_export.h"
@@ -35,7 +34,7 @@ class SESSIONS_EXPORT BaseSessionService {
TAB_RESTORE
};
- typedef base::Callback<void(ScopedVector<SessionCommand>)>
+ typedef base::Callback<void(std::vector<std::unique_ptr<SessionCommand>>)>
GetCommandsCallback;
// Creates a new BaseSessionService. After creation you need to invoke
@@ -55,7 +54,7 @@ class SESSIONS_EXPORT BaseSessionService {
// Returns the set of commands which were scheduled to be written. Once
// committed to the backend, the commands are removed from here.
- const ScopedVector<SessionCommand>& pending_commands() {
+ const std::vector<std::unique_ptr<SessionCommand>>& pending_commands() {
return pending_commands_;
}
@@ -112,7 +111,7 @@ class SESSIONS_EXPORT BaseSessionService {
scoped_refptr<SessionBackend> backend_;
// Commands we need to send over to the backend.
- ScopedVector<SessionCommand> pending_commands_;
+ std::vector<std::unique_ptr<SessionCommand>> pending_commands_;
// Whether the backend file should be recreated the next time we send
// over the commands.
« no previous file with comments | « chrome/browser/sessions/session_service_test_helper.cc ('k') | components/sessions/core/base_session_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698