Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 260053008: Trusted plugin: Miscellaneous cleanup. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Trusted plugin: Miscellaneous cleanup. This removes some unnecessary code in the trusted plugin. I broke this out to its own change while fixing up other things. BUG=239656 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266945

Patch Set 1 #

Total comments: 1

Patch Set 2 : add main thread check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -36 lines) Patch
M ppapi/native_client/src/trusted/plugin/module_ppapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 5 chunks +2 lines, -10 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 6 chunks +12 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
teravest
6 years, 7 months ago (2014-04-28 21:19:40 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/260053008/diff/1/ppapi/native_client/src/trusted/plugin/plugin.cc File ppapi/native_client/src/trusted/plugin/plugin.cc (right): https://codereview.chromium.org/260053008/diff/1/ppapi/native_client/src/trusted/plugin/plugin.cc#newcode964 ppapi/native_client/src/trusted/plugin/plugin.cc:964: return pp::URLUtil_Dev::Get()->DocumentCanRequest(this, pp::Var(url)); Hopefully this doesn't matter, but ...
6 years, 7 months ago (2014-04-28 23:01:44 UTC) #2
teravest
On 2014/04/28 23:01:44, dmichael wrote: > lgtm > > https://codereview.chromium.org/260053008/diff/1/ppapi/native_client/src/trusted/plugin/plugin.cc > File ppapi/native_client/src/trusted/plugin/plugin.cc (right): > ...
6 years, 7 months ago (2014-04-29 19:49:15 UTC) #3
teravest
6 years, 7 months ago (2014-04-29 20:12:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r266945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698