Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3918)

Unified Diff: bench/gen_bench_expectations.py

Issue 260053007: Adds a blacklist of SKPs to exclude from bench expectations. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/gen_bench_expectations.py
diff --git a/bench/gen_bench_expectations.py b/bench/gen_bench_expectations.py
index 628c985d65246c8b28f301881e50b4c98959a595..ffc64866b609601f412ad589c98b48f6e0b21c16 100644
--- a/bench/gen_bench_expectations.py
+++ b/bench/gen_bench_expectations.py
@@ -24,6 +24,10 @@ CONFIGS_TO_INCLUDE = ['simple_viewport_1000x1000',
'simple_viewport_1000x1000_scalar_1.100000_gpu',
]
+# List of flaky SKPs that should be excluded.
+SKPS_TO_EXCLUDE = ['desk_chalkboard.skp',
+ ]
+
def compute_ranges(benches):
"""Given a list of bench numbers, calculate the alert range.
@@ -57,7 +61,8 @@ def create_expectations_dict(revision_data_points):
bench_dict = {}
for point in revision_data_points:
if (point.time_type or # Not walltime which has time_type ''
- not point.config in CONFIGS_TO_INCLUDE):
+ not point.config in CONFIGS_TO_INCLUDE or
+ point.bench in SKPS_TO_EXCLUDE):
continue
key = (point.config, point.bench)
if key in bench_dict:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698