Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 260053003: Win DS Video Capture: do not add unsupported pixel formats to the capability list. (Closed)

Created:
6 years, 7 months ago by mcasas
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, phoglund_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Win DS Video Capture: do not add unsupported pixel formats to the capability list. This bug was uncovered by trying to use the Logitech C920 in the bots (see but). C920 has a new pixel format not in the list [1]. Since "unsupported" is anyway no good pixel format, it is skipped in CreateCapabilityMap() if it's enumerated. It's also skipped in GetDeviceSupportedFormats(). BUG=360512 [1] https://code.google.com/p/chromium/codesearch#chromium/src/media/video/capture/win/video_capture_device_win.cc&q=video_capture_device_win&sq=package:chromium&l=189 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266664

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M media/video/capture/win/video_capture_device_win.cc View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
mcasas
tommi@ PTAL. phoglund@ FYI (C920 fix).
6 years, 7 months ago (2014-04-28 15:17:49 UTC) #1
tommi (sloooow) - chröme
lgtm
6 years, 7 months ago (2014-04-28 15:19:43 UTC) #2
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 7 months ago (2014-04-28 15:36:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/260053003/60001
6 years, 7 months ago (2014-04-28 15:36:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 16:18:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 16:18:48 UTC) #6
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 7 months ago (2014-04-28 18:01:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/260053003/60001
6 years, 7 months ago (2014-04-28 18:01:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 18:53:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 18:53:46 UTC) #10
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 7 months ago (2014-04-28 19:10:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/260053003/60001
6 years, 7 months ago (2014-04-28 19:11:59 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 21:22:11 UTC) #13
Message was sent while issue was closed.
Change committed as 266664

Powered by Google App Engine
This is Rietveld 408576698