Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 260053002: Add WebRTC Logs directory to file access whitelist (Closed)

Created:
6 years, 7 months ago by Henrik Grunell
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Sergiu
Visibility:
Public.

Description

Add WebRTC Logs directory to file access whitelist BUG=362179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Henrik Grunell
6 years, 7 months ago (2014-04-28 14:04:57 UTC) #1
Randy Smith (Not in Mondays)
I have no clue about this file. Looking at the review list, sergiu@ has modified ...
6 years, 7 months ago (2014-04-28 14:40:23 UTC) #2
Sergiu
Hey, I've touched that file but sadly I have no idea about that whitelist. Looking ...
6 years, 7 months ago (2014-04-28 14:51:37 UTC) #3
mmenke
On 2014/04/28 14:51:37, Sergiu wrote: > Hey, I've touched that file but sadly I have ...
6 years, 7 months ago (2014-04-28 14:59:05 UTC) #4
Henrik Grunell
On 2014/04/28 14:59:05, mmenke wrote: > On 2014/04/28 14:51:37, Sergiu wrote: > > Hey, I've ...
6 years, 7 months ago (2014-04-29 06:17:37 UTC) #5
mmenke
LGTM
6 years, 7 months ago (2014-04-30 14:14:49 UTC) #6
mmenke
Quick question...Are these logs cleared when browser history is cleared? If not, they probably should ...
6 years, 7 months ago (2014-04-30 14:15:30 UTC) #7
Henrik Grunell
Yes they are cleared then. Den 30 apr 2014 16:15 skrev <mmenke@chromium.org>: > Quick question...Are ...
6 years, 7 months ago (2014-04-30 19:14:56 UTC) #8
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 7 months ago (2014-05-05 08:22:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/260053002/1
6 years, 7 months ago (2014-05-05 08:22:47 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 13:19:44 UTC) #11
Message was sent while issue was closed.
Change committed as 268163

Powered by Google App Engine
This is Rietveld 408576698