Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2600483002: Mark a Dartium test as failing (Closed)

Created:
4 years ago by Kevin Millikin (Google)
Modified:
4 years ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark a Dartium test as failing An HTML test has started failing due to a change in the VM's implementation of typed data. This is issue https://github.com/dart-lang/sdk/issues/28183. R=kasperl@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/96227c8bc33ff1766a5120e01d28ca5a8fabd05d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/html/html.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Kevin Millikin (Google)
4 years ago (2016-12-22 11:22:03 UTC) #1
kasperl
LGTM. https://codereview.chromium.org/2600483002/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/2600483002/diff/1/tests/html/html.status#newcode10 tests/html/html.status:10: canvas_pixel_array_type_alias_test/types2_runtimeTypeName: Fail # Issue 28183 Fail -> RuntimeError
4 years ago (2016-12-22 11:26:39 UTC) #2
Kevin Millikin (Google)
https://codereview.chromium.org/2600483002/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/2600483002/diff/1/tests/html/html.status#newcode10 tests/html/html.status:10: canvas_pixel_array_type_alias_test/types2_runtimeTypeName: Fail # Issue 28183 On 2016/12/22 11:26:39, kasperl ...
4 years ago (2016-12-22 11:29:33 UTC) #3
Kevin Millikin (Google)
4 years ago (2016-12-22 11:30:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
96227c8bc33ff1766a5120e01d28ca5a8fabd05d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698