Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Side by Side Diff: src/compiler/simplified-lowering.cc

Issue 2600443002: [turbofan] Lower StringCharCodeAt to a dedicated builtin. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/effect-control-linearizer.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/simplified-lowering.h" 5 #include "src/compiler/simplified-lowering.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/address-map.h" 9 #include "src/address-map.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 2184 matching lines...) Expand 10 before | Expand all | Expand 10 after
2195 case IrOpcode::kStringLessThanOrEqual: { 2195 case IrOpcode::kStringLessThanOrEqual: {
2196 return VisitBinop(node, UseInfo::AnyTagged(), 2196 return VisitBinop(node, UseInfo::AnyTagged(),
2197 MachineRepresentation::kTaggedPointer); 2197 MachineRepresentation::kTaggedPointer);
2198 } 2198 }
2199 case IrOpcode::kStringCharAt: { 2199 case IrOpcode::kStringCharAt: {
2200 VisitBinop(node, UseInfo::AnyTagged(), UseInfo::TruncatingWord32(), 2200 VisitBinop(node, UseInfo::AnyTagged(), UseInfo::TruncatingWord32(),
2201 MachineRepresentation::kTaggedPointer); 2201 MachineRepresentation::kTaggedPointer);
2202 return; 2202 return;
2203 } 2203 }
2204 case IrOpcode::kStringCharCodeAt: { 2204 case IrOpcode::kStringCharCodeAt: {
2205 // TODO(turbofan): Allow builtins to return untagged values.
2205 VisitBinop(node, UseInfo::AnyTagged(), UseInfo::TruncatingWord32(), 2206 VisitBinop(node, UseInfo::AnyTagged(), UseInfo::TruncatingWord32(),
2206 MachineRepresentation::kWord32); 2207 MachineRepresentation::kTaggedSigned);
2207 return; 2208 return;
2208 } 2209 }
2209 case IrOpcode::kStringFromCharCode: { 2210 case IrOpcode::kStringFromCharCode: {
2210 VisitUnop(node, UseInfo::TruncatingWord32(), 2211 VisitUnop(node, UseInfo::TruncatingWord32(),
2211 MachineRepresentation::kTaggedPointer); 2212 MachineRepresentation::kTaggedPointer);
2212 return; 2213 return;
2213 } 2214 }
2214 case IrOpcode::kStringFromCodePoint: { 2215 case IrOpcode::kStringFromCodePoint: {
2215 VisitUnop(node, UseInfo::TruncatingWord32(), 2216 VisitUnop(node, UseInfo::TruncatingWord32(),
2216 MachineRepresentation::kTaggedPointer); 2217 MachineRepresentation::kTaggedPointer);
(...skipping 1240 matching lines...) Expand 10 before | Expand all | Expand 10 after
3457 isolate(), graph()->zone(), callable.descriptor(), 0, flags, 3458 isolate(), graph()->zone(), callable.descriptor(), 0, flags,
3458 Operator::kNoProperties); 3459 Operator::kNoProperties);
3459 to_number_operator_.set(common()->Call(desc)); 3460 to_number_operator_.set(common()->Call(desc));
3460 } 3461 }
3461 return to_number_operator_.get(); 3462 return to_number_operator_.get();
3462 } 3463 }
3463 3464
3464 } // namespace compiler 3465 } // namespace compiler
3465 } // namespace internal 3466 } // namespace internal
3466 } // namespace v8 3467 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/effect-control-linearizer.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698