Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260043002: Cleanup: It is better to reuse the content API which already exist. (Closed)

Created:
6 years, 7 months ago by zino
Modified:
6 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup: It is better to reuse the content API which already exist. When saving a media file, we can reuse the WebContents::SaveFrame(). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +2 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
zino
Please take a look. Thank you.
6 years, 7 months ago (2014-04-28 13:28:15 UTC) #1
Avi (use Gerrit)
Wow. LGTM!
6 years, 7 months ago (2014-04-28 14:25:49 UTC) #2
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 7 months ago (2014-04-28 14:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/260043002/1
6 years, 7 months ago (2014-04-28 14:31:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 15:01:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_aosp
6 years, 7 months ago (2014-04-28 15:01:23 UTC) #6
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 7 months ago (2014-04-28 21:17:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/260043002/1
6 years, 7 months ago (2014-04-28 21:18:00 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:23:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_aosp
6 years, 7 months ago (2014-04-28 22:23:05 UTC) #10
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 7 months ago (2014-04-28 22:31:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/260043002/1
6 years, 7 months ago (2014-04-28 22:32:30 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 00:07:34 UTC) #13
Message was sent while issue was closed. 
Change committed as 266708

Powered by Google App Engine
This is Rietveld 408576698