Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1993)

Unified Diff: Source/modules/crypto/CryptoResultImpl.h

Issue 26004002: Decouple ScriptPromise creation from ScriptPromiseResolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/crypto/CryptoResultImpl.h
diff --git a/Source/modules/crypto/CryptoResultImpl.h b/Source/modules/crypto/CryptoResultImpl.h
index 707b546655a26775545497ca542b905394587e5a..0e930c7b49aa36a936638bb15b1ce7a5240d9c90 100644
--- a/Source/modules/crypto/CryptoResultImpl.h
+++ b/Source/modules/crypto/CryptoResultImpl.h
@@ -46,7 +46,7 @@ class CryptoResultImpl : public CryptoResult {
public:
~CryptoResultImpl();
- static PassRefPtr<CryptoResultImpl> create();
+ static PassRefPtr<CryptoResultImpl> create(ScriptPromise);
virtual void completeWithError() OVERRIDE;
virtual void completeWithBuffer(const WebKit::WebArrayBuffer&) OVERRIDE;
@@ -54,10 +54,8 @@ public:
virtual void completeWithKey(const WebKit::WebCryptoKey&) OVERRIDE;
virtual void completeWithKeyPair(const WebKit::WebCryptoKey& publicKey, const WebKit::WebCryptoKey& privateKey) OVERRIDE;
- ScriptPromise promise();
-
private:
- CryptoResultImpl();
+ explicit CryptoResultImpl(ScriptPromise);
void finish();
RefPtr<ScriptPromiseResolver> m_promiseResolver;

Powered by Google App Engine
This is Rietveld 408576698