Decouple ScriptPromise creation from ScriptPromiseResolver.

Source/bindings/v8/ScriptPromise.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 
 namespace WebCore {
 
 // ScriptPromise is the class for representing Promise values in C++ world.
 // ScriptPromise holds a Promise.
 // So holding a ScriptPromise as a member variable in DOM object causes
 // memory leaks since it has a reference from C++ to V8.
 //
 class ScriptPromise {
 public:
+    // Constructs an empty promise.
     ScriptPromise()
         : m_promise()
     {
     }
 
     explicit ScriptPromise(const ScriptValue& promise)
         : m_promise(promise)
     {
         ASSERT(!m_promise.hasNoValue());
     }
@@ skipping 27 matching lines @@
     bool hasNoValue() const
     {
         return m_promise.hasNoValue();
     }
 
     void clear()
     {
         m_promise.clear();
     }
 
+    // Creates a pending promise.
+    static ScriptPromise create();
+    // Creates a pending promise.
+    static ScriptPromise create(ScriptExecutionContext*);

[abarth-chromium, 2013/10/11 18:18:02]

Rather than write comments like these, we prefer if you put those ideas into the
names of the functions.  These function should be called:

ScriptPromise::createPending

Then all the callers will know that they're creating pending promises.

[yhirano, 2013/10/14 02:49:53]

Done.

+
 private:
     ScriptValue m_promise;
 };
 
 } // namespace WebCore
 
 
 #endif // ScriptPromise_h