Issue 260033002: Adding the assert() that checks for the correct view source highlighting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 260033002: Adding the assert() that checks for the correct view source highlighting (Closed)

Created:
6 years, 7 months ago by suyash

Modified:
6 years, 7 months ago

Reviewers:
apavlov, eseidel

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, ojan, vsevik

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Adding the assert() that checks for the correct view source highlighting This assert was disabled because it got triggered upon incorrect view-source highlighting.This happened because characters for the end tags were getting consumed by the tokenizer at the same time as it consumed the text of the script tag. Bug : https://bugs.webkit.org/show_bug.cgi?id=62971. Since it is fixed i think we can enable the assert. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172778

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	Source/core/html/parser/HTMLToken.h	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/260033002/1

6 years, 7 months ago (2014-04-28 15:40:59 UTC) #3

Message was sent while issue was closed.

+vsevik

Expand Messages | Collapse Messages