components/plugins/renderer/loadable_plugin_placeholder.cc - Issue 2600253003: Fix plugin placeholders not loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.cc

Issue 2600253003: Fix plugin placeholders not loading (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/plugins/renderer/loadable_plugin_placeholder.cc

diff --git a/components/plugins/renderer/loadable_plugin_placeholder.cc b/components/plugins/renderer/loadable_plugin_placeholder.cc

index 1f38fdbf87d685db9ef62e9ef21a33c1bc0b1be1..1669c07542206dfbd963c46e84c050fc2e26f700 100644

--- a/components/plugins/renderer/loadable_plugin_placeholder.cc

+++ b/components/plugins/renderer/loadable_plugin_placeholder.cc

@@ -129,9 +129,8 @@ void LoadablePluginPlaceholder::ReplacePlugin(blink::WebPlugin* new_plugin) {

container->invalidate();

container->reportGeometry();

- if (plugin()->focused())

- new_plugin->updateFocus(true, blink::WebFocusTypeNone);

container->element().setAttribute("title", plugin()->old_title());

+ plugin()->ReplayReceivedData(new_plugin);

plugin()->destroy();

}