components/subresource_filter/content/renderer/subresource_filter_agent.h - Issue 2600253002: Aggregate DocumentSubresourceFilter counters on page level.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent.h

Issue 2600253002: Aggregate DocumentSubresourceFilter counters on page level. (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc ('k') | components/subresource_filter/content/renderer/subresource_filter_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent.h

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent.h b/components/subresource_filter/content/renderer/subresource_filter_agent.h

index 4290bc9f181986154375b743dab6b828d4966d7a..62afdc4c2f57a70524290ed2526502377da5d523 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent.h

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent.h

@@ -10,6 +10,7 @@

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

+#include "components/subresource_filter/content/common/document_load_statistics.h"

#include "components/subresource_filter/core/common/activation_state.h"

#include "content/public/renderer/render_frame_observer.h"

#include "url/gurl.h"

@@ -56,11 +57,9 @@ class SubresourceFilterAgent

// the most recently committed load. Not called if all resources are allowed.

virtual void SignalFirstSubresourceDisallowedForCommittedLoad();

- // Informs the browser about the time spent by DocumentSubresourceFilter in

- // allowLoad calls while evaluating subresource loads for the current frame.

+ // Sends statistics about the DocumentSubresourceFilter's work to the browser.

virtual void SendDocumentLoadStatistics(

- base::TimeDelta evaluation_total_wall_duration,

- base::TimeDelta evaluation_total_cpu_duration);

+ const DocumentLoadStatistics& statistics);

private:

void OnActivateForProvisionalLoad(ActivationState activation_state,