components/subresource_filter/content/renderer/document_subresource_filter.cc - Issue 2600253002: Aggregate DocumentSubresourceFilter counters on page level.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/document_subresource_filter.cc

Issue 2600253002: Aggregate DocumentSubresourceFilter counters on page level. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/content/common/subresource_filter_messages.h ('K') | « components/subresource_filter/content/renderer/document_subresource_filter.h ('k') | components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc » ('j') | components/subresource_filter/content/renderer/subresource_filter_agent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/document_subresource_filter.cc

diff --git a/components/subresource_filter/content/renderer/document_subresource_filter.cc b/components/subresource_filter/content/renderer/document_subresource_filter.cc

index 12afb7daf2acfa896b5607425d342dc28440250d..3debaeaec4ecc7d0f96e228f83e25b47c2359530 100644

--- a/components/subresource_filter/content/renderer/document_subresource_filter.cc

+++ b/components/subresource_filter/content/renderer/document_subresource_filter.cc

@@ -163,7 +163,7 @@ bool DocumentSubresourceFilter::allowLoad(

++statistics_.num_loads_matching_rules;

if (activation_state_ == ActivationState::ENABLED) {

if (!first_disallowed_load_callback_.is_null()) {

- DCHECK_EQ(statistics_.num_loads_disallowed, 0u);

+ DCHECK_EQ(statistics_.num_loads_disallowed, 0);

first_disallowed_load_callback_.Run();

first_disallowed_load_callback_.Reset();

}