Issue 260012: Use more images from the pak files...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 260012: Use more images from the pak files... (Closed)

Created:
11 years, 2 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use more images from the pak files - Remove the alert icon from the download item dangerous download xib. - Remove the download fav icon from the download shelf xib. - Update the download shelf to fetch the image from the pak. - Update the download item to fetch the alert image from the pak. - Update the bookmark bar to fetch the folder icon from the xib and cache it. - Remove the three images from the bundles. BUG=20230 TEST=all three still show their images Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28392

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1147 lines, -128 lines)			Patch
M	chrome/app/nibs/DownloadItem.xib	View	1	24 chunks	+547 lines, -44 lines	0 comments	Download
M	chrome/app/nibs/DownloadShelf.xib	View	1	20 chunks	+577 lines, -80 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_controller.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_controller.mm	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/download_item_controller.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/download_item_controller.mm	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/download_shelf_controller.mm	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

lg http://codereview.chromium.org/260012/diff/1/4 File chrome/browser/cocoa/bookmark_bar_controller.mm (right): http://codereview.chromium.org/260012/diff/1/4#newcode79 Line 79: folderImage_.reset(rb.GetNSImageNamed(IDR_BOOKMARK_BAR_FOLDER)); DCHECK that you have an image?

11 years, 2 months ago (2009-10-05 20:06:49 UTC) #2

Updated to pass unittest (caught a missing retain)

Expand Messages | Collapse Messages