Several background pattern fixes on the Mac....

chrome/browser/cocoa/tab_strip_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/tab_strip_controller.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/mac_util.h"
 #include "base/nsimage_cache_mac.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_dll_resource.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/find_bar.h"
 #include "chrome/browser/find_bar_controller.h"
 #include "chrome/browser/metrics/user_metrics.h"
 #include "chrome/browser/profile.h"
 #import "chrome/browser/cocoa/browser_window_controller.h"
 #import "chrome/browser/cocoa/constrained_window_mac.h"
 #import "chrome/browser/cocoa/tab_strip_view.h"
-#import "chrome/browser/cocoa/tab_cell.h"
 #import "chrome/browser/cocoa/tab_contents_controller.h"
 #import "chrome/browser/cocoa/tab_controller.h"
 #import "chrome/browser/cocoa/tab_strip_model_observer_bridge.h"
 #import "chrome/browser/cocoa/tab_view.h"
 #import "chrome/browser/cocoa/throbber_view.h"
 #include "chrome/browser/tab_contents/navigation_controller.h"
 #include "chrome/browser/tab_contents/navigation_entry.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents/tab_contents_view.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
@@ skipping 387 matching lines @@
       [NSAnimationContext beginGrouping];
       [[NSAnimationContext currentContext] setDuration:0.000001];
       tabFrame.origin.x = placeholderFrame_.origin.x;
       // TODO(alcor): reenable this
       //tabFrame.size.height += 10.0 * placeholderStretchiness_;
       id target = animate ? [[tab view] animator] : [tab view];
       [target setFrame:tabFrame];
       [NSAnimationContext endGrouping];
 
       // Store the frame by identifier to aviod redundant calls to animator.
-      NSValue *identifier = [NSValue valueWithPointer:[tab view]];
+      NSValue* identifier = [NSValue valueWithPointer:[tab view]];
       [targetFrames_ setObject:[NSValue valueWithRect:tabFrame]
                         forKey:identifier];
       continue;
     } else {
       // If our left edge is to the left of the placeholder's left, but our mid
       // is to the right of it we should slide over to make space for it.
       if (placeholderTab_ && gap < 0 && NSMidX(tabFrame) > minX) {
         gap = i;
         offset += NSWidth(tabFrame);
         offset -= kTabOverlap;
         tabFrame.origin.x = offset;
       }
 
       // Animate the tab in by putting it below the horizon, but don't bother
       // if we only have 1 tab.
       BOOL shouldAnimate = animate && [tabContentsArray_ count] > 1;
       if (newTab && visible && shouldAnimate) {
         [[tab view] setFrame:NSOffsetRect(tabFrame, 0, -NSHeight(tabFrame))];
       }
 
       // Set the width. Selected tabs are slightly wider when things get
       // really small and thus we enforce a different minimum width.
       tabFrame.size.width =
           [tab selected] ? MAX(baseTabWidth, kMinSelectedTabWidth) :
                            baseTabWidth;
 
       // Check the frame by identifier to avoid redundant calls to animator.
       id frameTarget = visible && animate ? [[tab view] animator] : [tab view];
-      NSValue *identifier = [NSValue valueWithPointer:[tab view]];
-      NSValue *oldTargetValue = [targetFrames_ objectForKey:identifier];
+      NSValue* identifier = [NSValue valueWithPointer:[tab view]];
+      NSValue* oldTargetValue = [targetFrames_ objectForKey:identifier];
       if (!oldTargetValue ||
           !NSEqualRects([oldTargetValue rectValue], tabFrame)) {
         [frameTarget setFrame:tabFrame];
         [targetFrames_ setObject:[NSValue valueWithRect:tabFrame]
                           forKey:identifier];
       }
       enclosingRect = NSUnionRect(tabFrame, enclosingRect);
     }
 
     offset += NSWidth(tabFrame);
@@ skipping 164 matching lines @@
   // Clear the tab controller's target.
   // TODO(viettrungluu): [crbug.com/23829] Find a better way to handle the tab
   // controller's target.
   TabController* tabController = [tabArray_ objectAtIndex:index];
   [tabController setTarget:nil];
 
   if ([hoveredTab_ isEqual:tab]) {
     hoveredTab_ = nil;
   }
 
-  NSValue *identifier = [NSValue valueWithPointer:tab];
+  NSValue* identifier = [NSValue valueWithPointer:tab];
   [targetFrames_ removeObjectForKey:identifier];
 
   // Once we're totally done with the tab, delete its controller
   [tabArray_ removeObjectAtIndex:index];
 
   // Send a broadcast that the number of tabs have changed.
   [[NSNotificationCenter defaultCenter]
       postNotificationName:kTabStripNumberOfTabsChanged
                     object:self];
 
@@ skipping 120 matching lines @@
   [tabContentsArray_ insertObject:movedController.get() atIndex:to];
   scoped_nsobject<TabView> movedView(
       [[tabArray_ objectAtIndex:from] retain]);
   [tabArray_ removeObjectAtIndex:from];
   [tabArray_ insertObject:movedView.get() atIndex:to];
 
   [self layoutTabs];
 }
 
 - (void)setFrameOfSelectedTab:(NSRect)frame {
-  NSView *view = [self selectedTabView];
-  NSValue *identifier = [NSValue valueWithPointer:view];
+  NSView* view = [self selectedTabView];
+  NSValue* identifier = [NSValue valueWithPointer:view];
   [targetFrames_ setObject:[NSValue valueWithRect:frame]
                     forKey:identifier];
   [view setFrame:frame];
 }
 
-- (NSView *)selectedTabView {
+- (NSView*)selectedTabView {
   int selectedIndex = tabModel_->selected_index();
   return [self viewAtIndex:selectedIndex];
 }
 
 // Find the index based on the x coordinate of the placeholder. If there is
 // no placeholder, this returns the end of the tab strip.
 - (int)indexOfPlaceholder {
   double placeholderX = placeholderFrame_.origin.x;
   int index = 0;
   int location = 0;
@@ skipping 27 matching lines @@
 // is no placeholder, it will go at the end. Used when dragging from another
 // window when we don't have access to the TabContents as part of our strip.
 - (void)dropTabContents:(TabContents*)contents {
   int index = [self indexOfPlaceholder];
 
   // Insert it into this tab strip. We want it in the foreground and to not
   // inherit the current tab's group.
   tabModel_->InsertTabContentsAt(index, contents, true, false);
 }
 
-- (void)applyTheme {
-  for (TabController* tab in tabArray_.get()) {
-    [tab applyTheme];
-  }
-}
-
 // Called when the tab strip view changes size. As we only registered for
 // changes on our view, we know it's only for our view. Layout w/out
 // animations since they are blocked by the resize nested runloop. We need
 // the views to adjust immediately. Neither the tabs nor their z-order are
 // changed, so we don't need to update the subviews.
 - (void)tabViewFrameChanged:(NSNotification*)info {
   [self layoutTabsWithAnimation:NO regenerateSubviews:NO];
 }
 
 - (BOOL)inRapidClosureMode {
   return availableResizeWidth_ != kUseFullAvailableWidth;
 }
 
-- (void)mouseMoved:(NSEvent *)event {
+- (void)mouseMoved:(NSEvent*)event {
   // Use hit test to figure out what view we are hovering over.
   TabView* targetView = (TabView*)[tabView_ hitTest:[event locationInWindow]];
   if (![targetView isKindOfClass:[TabView class]]) {
     if ([[targetView superview] isKindOfClass:[TabView class]]) {
       targetView = (TabView*)[targetView superview];
     } else {
       targetView = nil;
     }
   }
 
@@ skipping 115 matching lines @@
   BrowserWindowController* controller =
       (BrowserWindowController*)[[switchView_ window] windowController];
   DCHECK(index >= 0);
   if (index >= 0) {
     [controller setTab:[self viewAtIndex:index] isDraggable:YES];
   }
 }
 
 
 @end