Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 260003006: Added a Isolate* parameter to Serializer::enabled(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
887 // Make sure that the lithium instruction has either no fixed register 887 // Make sure that the lithium instruction has either no fixed register
888 // constraints in temps or the result OR no uses that are only used at 888 // constraints in temps or the result OR no uses that are only used at
889 // start. If this invariant doesn't hold, the register allocator can decide 889 // start. If this invariant doesn't hold, the register allocator can decide
890 // to insert a split of a range immediately before the instruction due to an 890 // to insert a split of a range immediately before the instruction due to an
891 // already allocated register needing to be used for the instruction's fixed 891 // already allocated register needing to be used for the instruction's fixed
892 // register constraint. In this case, The register allocator won't see an 892 // register constraint. In this case, The register allocator won't see an
893 // interference between the split child and the use-at-start (it would if 893 // interference between the split child and the use-at-start (it would if
894 // the it was just a plain use), so it is free to move the split child into 894 // the it was just a plain use), so it is free to move the split child into
895 // the same register that is used for the use-at-start. 895 // the same register that is used for the use-at-start.
896 // See https://code.google.com/p/chromium/issues/detail?id=201590 896 // See https://code.google.com/p/chromium/issues/detail?id=201590
897 if (!(instr->ClobbersRegisters() && instr->ClobbersDoubleRegisters())) { 897 if (!(instr->ClobbersRegisters() &&
898 instr->ClobbersDoubleRegisters(isolate()))) {
898 int fixed = 0; 899 int fixed = 0;
899 int used_at_start = 0; 900 int used_at_start = 0;
900 for (UseIterator it(instr); !it.Done(); it.Advance()) { 901 for (UseIterator it(instr); !it.Done(); it.Advance()) {
901 LUnallocated* operand = LUnallocated::cast(it.Current()); 902 LUnallocated* operand = LUnallocated::cast(it.Current());
902 if (operand->IsUsedAtStart()) ++used_at_start; 903 if (operand->IsUsedAtStart()) ++used_at_start;
903 } 904 }
904 if (instr->Output() != NULL) { 905 if (instr->Output() != NULL) {
905 if (LUnallocated::cast(instr->Output())->HasFixedPolicy()) ++fixed; 906 if (LUnallocated::cast(instr->Output())->HasFixedPolicy()) ++fixed;
906 } 907 }
907 for (TempIterator it(instr); !it.Done(); it.Advance()) { 908 for (TempIterator it(instr); !it.Done(); it.Advance()) {
(...skipping 1702 matching lines...) Expand 10 before | Expand all | Expand 10 after
2610 LOperand* index = UseTempRegister(instr->index()); 2611 LOperand* index = UseTempRegister(instr->index());
2611 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2612 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2612 LInstruction* result = DefineSameAsFirst(load); 2613 LInstruction* result = DefineSameAsFirst(load);
2613 return AssignPointerMap(result); 2614 return AssignPointerMap(result);
2614 } 2615 }
2615 2616
2616 2617
2617 } } // namespace v8::internal 2618 } } // namespace v8::internal
2618 2619
2619 #endif // V8_TARGET_ARCH_X64 2620 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698