Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 260003006: Added a Isolate* parameter to Serializer::enabled(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 // property. 466 // property.
467 void StubCompiler::GenerateCheckPropertyCell(MacroAssembler* masm, 467 void StubCompiler::GenerateCheckPropertyCell(MacroAssembler* masm,
468 Handle<JSGlobalObject> global, 468 Handle<JSGlobalObject> global,
469 Handle<Name> name, 469 Handle<Name> name,
470 Register scratch, 470 Register scratch,
471 Label* miss) { 471 Label* miss) {
472 Handle<PropertyCell> cell = 472 Handle<PropertyCell> cell =
473 JSGlobalObject::EnsurePropertyCell(global, name); 473 JSGlobalObject::EnsurePropertyCell(global, name);
474 ASSERT(cell->value()->IsTheHole()); 474 ASSERT(cell->value()->IsTheHole());
475 Handle<Oddball> the_hole = masm->isolate()->factory()->the_hole_value(); 475 Handle<Oddball> the_hole = masm->isolate()->factory()->the_hole_value();
476 if (Serializer::enabled()) { 476 if (Serializer::enabled(masm->isolate())) {
477 __ mov(scratch, Immediate(cell)); 477 __ mov(scratch, Immediate(cell));
478 __ cmp(FieldOperand(scratch, PropertyCell::kValueOffset), 478 __ cmp(FieldOperand(scratch, PropertyCell::kValueOffset),
479 Immediate(the_hole)); 479 Immediate(the_hole));
480 } else { 480 } else {
481 __ cmp(Operand::ForCell(cell), Immediate(the_hole)); 481 __ cmp(Operand::ForCell(cell), Immediate(the_hole));
482 } 482 }
483 __ j(not_equal, miss); 483 __ j(not_equal, miss);
484 } 484 }
485 485
486 486
(...skipping 953 matching lines...) Expand 10 before | Expand all | Expand 10 after
1440 Handle<Code> LoadStubCompiler::CompileLoadGlobal( 1440 Handle<Code> LoadStubCompiler::CompileLoadGlobal(
1441 Handle<HeapType> type, 1441 Handle<HeapType> type,
1442 Handle<GlobalObject> global, 1442 Handle<GlobalObject> global,
1443 Handle<PropertyCell> cell, 1443 Handle<PropertyCell> cell,
1444 Handle<Name> name, 1444 Handle<Name> name,
1445 bool is_dont_delete) { 1445 bool is_dont_delete) {
1446 Label miss; 1446 Label miss;
1447 1447
1448 HandlerFrontendHeader(type, receiver(), global, name, &miss); 1448 HandlerFrontendHeader(type, receiver(), global, name, &miss);
1449 // Get the value from the cell. 1449 // Get the value from the cell.
1450 if (Serializer::enabled()) { 1450 if (Serializer::enabled(isolate())) {
1451 __ mov(eax, Immediate(cell)); 1451 __ mov(eax, Immediate(cell));
1452 __ mov(eax, FieldOperand(eax, PropertyCell::kValueOffset)); 1452 __ mov(eax, FieldOperand(eax, PropertyCell::kValueOffset));
1453 } else { 1453 } else {
1454 __ mov(eax, Operand::ForCell(cell)); 1454 __ mov(eax, Operand::ForCell(cell));
1455 } 1455 }
1456 1456
1457 // Check for deleted property if property can actually be deleted. 1457 // Check for deleted property if property can actually be deleted.
1458 if (!is_dont_delete) { 1458 if (!is_dont_delete) {
1459 __ cmp(eax, factory()->the_hole_value()); 1459 __ cmp(eax, factory()->the_hole_value());
1460 __ j(equal, &miss); 1460 __ j(equal, &miss);
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
1568 // ----------------------------------- 1568 // -----------------------------------
1569 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1569 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1570 } 1570 }
1571 1571
1572 1572
1573 #undef __ 1573 #undef __
1574 1574
1575 } } // namespace v8::internal 1575 } } // namespace v8::internal
1576 1576
1577 #endif // V8_TARGET_ARCH_IA32 1577 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/ic.cc » ('j') | src/objects-visiting-inl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698