Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 260003005: Add nacl_loader_unittests to the chromium_builder_tests (Closed)

Created:
6 years, 7 months ago by hamaji
Modified:
6 years, 7 months ago
Reviewers:
hidehiko, Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

Add nacl_loader_unittests to the chromium_builder_tests TEST=ninja -C out/Release chromium_builder_tests BUG=364751 R=hidehiko@chromium.org TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hamaji
It seems the trybot is failing. http://build.chromium.org/p/tryserver.chromium/builders/linux_rel_precise32/builds/442
6 years, 7 months ago (2014-04-28 08:27:10 UTC) #1
hidehiko
lgtm
6 years, 7 months ago (2014-04-28 09:25:54 UTC) #2
hamaji
Let me land this with TBR=mseaborn. The build of tryjobs seem to be OK.
6 years, 7 months ago (2014-04-28 09:44:06 UTC) #3
hamaji
The CQ bit was checked by hamaji@chromium.org
6 years, 7 months ago (2014-04-28 09:44:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hamaji@chromium.org/260003005/1
6 years, 7 months ago (2014-04-28 09:45:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 10:16:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 7 months ago (2014-04-28 10:16:20 UTC) #7
hamaji
Committed patchset #1 manually as r266521 (presubmit successful).
6 years, 7 months ago (2014-04-28 12:28:51 UTC) #8
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-04-28 13:16:27 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/256933004/ by jochen@chromium.org.

The reason for reverting is: Unconditionally adds a nacl dependency, breaks
disable_nacl=1 builds.

Powered by Google App Engine
This is Rietveld 408576698