Remove worker pool names from TaskScheduler.TaskLatency.* histograms.

base/task_scheduler/task_tracker_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/task_scheduler/task_tracker.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
+#include "base/metrics/histogram_base.h"
+#include "base/metrics/histogram_samples.h"
+#include "base/metrics/statistics_recorder.h"
 #include "base/sequence_token.h"
 #include "base/sequenced_task_runner.h"
 #include "base/single_thread_task_runner.h"
 #include "base/synchronization/atomic_flag.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/task_scheduler/scheduler_lock.h"
 #include "base/task_scheduler/task.h"
 #include "base/task_scheduler/task_traits.h"
 #include "base/test/gtest_util.h"
 #include "base/test/test_simple_task_runner.h"
@@ skipping 849 matching lines @@
 // task.
 TEST(TaskSchedulerTaskTrackerWaitAllowedTest, WaitAllowed) {
   // Run the test on the separate thread since it is not possible to reset the
   // "wait allowed" bit of a thread without being a friend of
   // ThreadRestrictions.
   WaitAllowedTestThread wait_allowed_test_thread;
   wait_allowed_test_thread.Start();
   wait_allowed_test_thread.Join();
 }
 
+// Verify that TaskScheduler.TaskLatency.* histograms are correctly recorded
+// when a task runs.
+TEST(TaskSchedulerTaskTrackerHistogramTest, TaskLatency) {
+  auto statistics_recorder = StatisticsRecorder::CreateTemporaryForTesting();
+
+  TaskTracker tracker;
+
+  struct {
+    const TaskTraits traits;
+    HistogramBase* const expected_histogram;
+  } tests[] = {
+      {TaskTraits().WithPriority(TaskPriority::BACKGROUND),
+       tracker.task_latency_histograms_[static_cast<int>(
+           TaskPriority::BACKGROUND)][0]},
+      {TaskTraits().WithPriority(TaskPriority::BACKGROUND).MayBlock(),
+       tracker.task_latency_histograms_[static_cast<int>(
+           TaskPriority::BACKGROUND)][1]},
+      {TaskTraits()
+           .WithPriority(TaskPriority::BACKGROUND)
+           .WithBaseSyncPrimitives(),
+       tracker.task_latency_histograms_[static_cast<int>(
+           TaskPriority::BACKGROUND)][1]},
+      {TaskTraits().WithPriority(TaskPriority::USER_VISIBLE),
+       tracker.task_latency_histograms_[static_cast<int>(
+           TaskPriority::USER_VISIBLE)][0]},
+      {TaskTraits().WithPriority(TaskPriority::USER_VISIBLE).MayBlock(),
+       tracker.task_latency_histograms_[static_cast<int>(
+           TaskPriority::USER_VISIBLE)][1]},
+      {TaskTraits()
+           .WithPriority(TaskPriority::USER_VISIBLE)
+           .WithBaseSyncPrimitives(),
+       tracker.task_latency_histograms_[static_cast<int>(
+           TaskPriority::USER_VISIBLE)][1]},
+      {TaskTraits().WithPriority(TaskPriority::USER_BLOCKING),
+       tracker.task_latency_histograms_[static_cast<int>(
+           TaskPriority::USER_BLOCKING)][0]},
+      {TaskTraits().WithPriority(TaskPriority::USER_BLOCKING).MayBlock(),
+       tracker.task_latency_histograms_[static_cast<int>(
+           TaskPriority::USER_BLOCKING)][1]},
+      {TaskTraits()
+           .WithPriority(TaskPriority::USER_BLOCKING)
+           .WithBaseSyncPrimitives(),
+       tracker.task_latency_histograms_[static_cast<int>(
+           TaskPriority::USER_BLOCKING)][1]}};

[gab, 2017/01/05 19:25:46]

Use HistogramTester instead of friending and using the internal value in the
test.

[fdoray, 2017/01/05 20:13:38]

Done.

+
+  for (const auto& test : tests) {

[gab, 2017/01/05 19:25:46]

Interesting use of auto! I thought something was wrong with the above struct as
it doesn't declare a type but I guess auto is fine with that (i.e. auto is the
only valid type here!) :-O

[fdoray, 2017/01/05 20:13:38]

Acknowledged.

+    // Take a snapshot of the histogram so that the snapshot below only contains
+    // increments that occurred within this scope.
+    test.expected_histogram->SnapshotDelta();
+
+    auto task =
+        MakeUnique<Task>(FROM_HERE, Bind(&DoNothing), test.traits, TimeDelta());
+    ASSERT_TRUE(tracker.WillPostTask(task.get()));
+    EXPECT_TRUE(tracker.RunTask(std::move(task), SequenceToken::Create()));
+    EXPECT_EQ(1, test.expected_histogram->SnapshotDelta()->TotalCount());
+  }
+}
+
 }  // namespace internal
 }  // namespace base